feat(core): add change impact analysis - #329
Closed
joesobo wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: c76e847 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
change-impactreport for exact File paths and Symbol IDscodegraphy impact <node...>as a multi-target adapter boundary for changed File listsAlgorithm and limits
The report expands exact File targets to their indexed Symbols, then performs deterministic breadth-first traversal over incoming typed Relationships. It excludes structural
nestsEdges from impact evidence.Ranking is:
The CLI uses a maximum depth of 3, visits at most 2,000 Nodes, returns 20 affected Files by default, and accepts at most 100 results. The report states all active limits and any truncation reason.
Test classification uses File paths. Public boundary evidence requires an explicit
reexportRelationship. Package boundaries compare nearest indexedpackage.jsonroots. These are deterministic graph heuristics, not runtime proof or confidence scores.The Core report does not read Git state. Its multi-target input is the adapter boundary for a caller that has already resolved a changed File list.
Example
Verification
Passing:
git diff --checkQuality work still in progress:
packages/core/src/graphQuery/changeImpact/model.tsscored 74.29%, below the required 90%model.test.tsfiles and failed when a write-coordination child process tried to import Stryker's instrumented HTTP module URL; the explicit matching test include avoided that tool interactionThis PR is a draft until the change-impact module is split or the scoped mutation score reaches 90%.
Tradeoffs