removed quotes to be able to specify multiple additional arguments - #212
Open
ppaulis wants to merge 1 commit into
Open
removed quotes to be able to specify multiple additional arguments#212ppaulis wants to merge 1 commit into
ppaulis wants to merge 1 commit into
Conversation
Signed-off-by: Pascal Paulis <ppaulis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @joedwards32,
I'm trying to add multiple additional arguments like this in my server config:
It works fine with a single argument, but as soon as I add a second one like in the example above, it stops working. My guess is that it's because of the quotes:
"${CS2_ADDITIONAL_ARGS}"in
entry.shThis PR should fix the problem. Alternatively I could add new env vars for all three properties.
Thanks,
best regards,
Pascal