fix(fleet-watch): retry transport failures before paging UNREACHABLE (#972) - #987
Merged
Conversation
jinon86
approved these changes
Aug 6, 2026
jinon86
left a comment
jinon86
left a comment
Contributor
There was a problem hiding this comment.
Approved after explicit operator authorization using the Seoseo-held jinon86 credential.
…972) adapter-fleet-watch ran at a 42% failure rate (8/19 runs) because each node got exactly one SSH attempt: a transient blip and a real outage produced the identical UNREACHABLE page. Two of the four sampled failures were nodes that recovered minutes later with no human action; the one real outage (daegyo 2026-08-06, #968) was buried in the noise. The probe loop now retries transport failures (empty output) with a delay before declaring UNREACHABLE: CCC_FLEET_RETRIES extra attempts (default 2, capped at 5) spaced CCC_FLEET_RETRY_DELAY seconds apart (default 10, capped at 120). A node that answers is never re-asked, so DOWN stays a single-answer verdict and exit/notification semantics are unchanged — retries only absorb blips, they never mask a verdict. Issue proposals 2 (bounded failure summary in runHistory; schema change) and 3 (consecutive-failure escalation; cross-run state) are deliberately out of scope for this PR. Co-Authored-By: Kimi K3 <noreply@moonshot.cn>
seoseo-ai
force-pushed
the
fix/972-fleet-watch-retry
branch
from
August 6, 2026 09:34
632e91d to
be1b638
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
adapter-fleet-watch의 노드당 1회 SSH 시도로 일시 blip과 실제 장애가 동일한UNREACHABLE페이지로 울리던 문제(실패율 42%)를 수정합니다 (#972).CCC_FLEET_RETRIES(기본 2, 상한 5)회,CCC_FLEET_RETRY_DELAY(기본 10초, 상한 120초) 간격UNREACHABLE+ nonzero exit → 알림 경로 불변Evidence
scripts/fleet-bridge-watch.test.sh: PASS=48 FAIL=0 — 신규 6건(blip 회수 OK·정확히 2회 시도 / 지속 실패 1회 보고·3회 시도 / DOWN 무재시도 / RETRIES=0 단일 시도)Closes #972