Repository navigation
fix(client): dimming keeps the scrollbar's space, so the dock stays put - #352
Merged
Merged
Conversation
Dimming hid the page's scrollbar, which gave its width back to the page: the dock and anything else centered moved by half a scrollbar on every dim and wake. The page now keeps the space (scrollbar-gutter: stable) while the scrollbar is hidden, and the gutter is the dimmed page's black.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While a display is dimmed,
displayDim.jshides scrollbars, because Chrome draws them outside the brightness filter at full brightness. Hiding the page's scrollbar gives its width back to the page, so on a browser with always-visible scrollbars the dock and anything else centered moved by half a scrollbar (4px here) on every dim, and back on every wake.What changes
While dimmed, the page keeps the scrollbar's space (
scrollbar-gutter: stableonhtml) and the scrollbar stays hidden. The gutter shows the dimmed page's black. Scrollbars inside widgets are hidden as before.Testing
vitest832/832,check:i18nclean.