Repository navigation
docs(themes): the heading tokens, and setting capitals in both places - #351
Merged
Merged
Conversation
The theme guide's token table left out --hg-heading-transform and --hg-heading-letter-spacing, and nothing said that mui.headingTransform and --hg-heading-transform cover different halves: core widgets are MUI, plugins are CSS. Since jherforth#348, buttons default to sentence case and plugins share the widget header, so a theme that sets only one gets core and plugin headers that don't match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The theme guide's token table leaves out
--hg-heading-transformand--hg-heading-letter-spacing, and doesn't say that capitals take two settings.mui.headingTransformcovers core widgets (MUI).--hg-heading-transformcovers plugins (CSS). Since #348, buttons default to sentence case and plugins share the widget header, so a theme that sets only one gets core and plugin headers that don't match.What changes
docs/guides/theme-development.mdonly: