Skip to content

chore: update to node 24 - #328

Merged
MaorEJFrog merged 3 commits into
jfrog:masterfrom
mdgreenwald:feat/node24
Mar 17, 2026
Merged

chore: update to node 24#328
MaorEJFrog merged 3 commits into
jfrog:masterfrom
mdgreenwald:feat/node24

Conversation

@mdgreenwald

@mdgreenwald mdgreenwald commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

This PR upgrades the action to Node 24 ahead of the Node 20 deprecation on June 2nd 2026.

Fixes: #306

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Signed-off-by: Matthew Greenwald <mdgreenwald@gmail.com>
Signed-off-by: Matthew Greenwald <mdgreenwald@gmail.com>
Signed-off-by: Matthew Greenwald <mdgreenwald@gmail.com>

@MaorEJFrog MaorEJFrog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! To ensure full Node 24 compatibility, we also need to update
the @actions/* dependencies. Can you add these changes to your PR?

npm install @actions/core@^3.0.0 @actions/exec@^3.0.0 ...

@mdgreenwald

mdgreenwald commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for this PR! To ensure full Node 24 compatibility, we also need to update the @actions/* dependencies. Can you add these changes to your PR?

npm install @actions/core@^3.0.0 @actions/exec@^3.0.0 ...

Unfortunately actions core v3 requires some pretty big changes because it is ESM only.
https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md#300

How do you all want to proceed?

@wvxi

wvxi commented Mar 17, 2026

Copy link
Copy Markdown

Please, dont delay this merge!! Also, i see this check failedÑ
https://github.com/jfrog/setup-jfrog-cli/actions/runs/23157879961/job/67277426955?pr=328#step:2:27

@mdgreenwald

Copy link
Copy Markdown
Contributor Author

Please, dont delay this merge!! Also, i see this check failedÑ

https://github.com/jfrog/setup-jfrog-cli/actions/runs/23157879961/job/67277426955?pr=328#step:2:27

Yes, that check probably fails in main as well. My permissions commit should fix it.

@MaorEJFrog MaorEJFrog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for security review

@github-actions

Copy link
Copy Markdown

👍 Frogbot scanned this pull request and did not find any new security issues.


@MaorEJFrog
MaorEJFrog merged commit 0f6e5a3 into jfrog:master Mar 17, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation of Node 20 on GitHub Actions runners

3 participants