RTECO-945: Wire jf apk commands and e2e tests by naveenku-jfrog · Pull Request #3561 · jfrog/jfrog-cli

naveenku-jfrog · 2026-06-19T20:34:43Z

Summary

Wires the Alpine APK integration into the JFrog CLI frontend: registers jf apk subcommands, adds CLI flags, package aliasing (Ghost Frog), and a comprehensive e2e test suite. This is the user-facing entry point for the full Alpine APK feature.

Depends on:

What Changed

`buildtools/cli.go`

ApkCmd() — dispatches jf apk config, jf apk upload, and all native apk subcommands (add, upgrade, etc.)
Extracts JFrog-specific flags (--repo, --server-id, --alpine-version, --user, --password, --build-name, --build-number, --module, --project) before forwarding remaining args to native apk
Fail-fast on unknown --server-id: if --server-id is explicitly provided but not found in the config, the command errors immediately — consistent with jf npm, jf pip, jf mvn, etc.
Falls back to the default server silently when --server-id is omitted (allows jf apk add to work without Artifactory for basic usage)

`utils/cliutils/commandsflags.go`

New Apk flag group: --repo, --server-id, --alpine-version, --user, --password, --build-name, --build-number, --module, --project

`docs/buildtools/apkcommand/help.go`

GetDescription(), GetAIDescription(), Usage, GetArguments() for jf apk help text and AI help coverage

`packagealias/packagealias.go`

Registers apk as a Ghost Frog package alias so jf apk add curl works identically to jfrog apk add curl — consistent with npm, pip, mvn, etc.

`apk_test.go`

Full end-to-end test suite (35 test cases) covering:

Category	Tests
Basic build-info	`NoBuildFlags`, `WithBuildFlags`, `BuildNameFromEnvVars`
Dependency collection	`DepIDFormat`, `DepChecksums`, `DepRequestedBy`, `TransitiveDeps`
Scopes	`ScopeProduction`, `ScopeTransitive`
Repo / server config	`MissingRepo`, `InvalidRepo`, `UnknownServerID`, `ArtifactoryUnreachable`, `VirtualRepoAggregates`
Upload	`Upload`, `UploadWithBuildInfo`, `CIVCSPropertiesStamped`
Config	`Config`, `ConfigMissingServerID`
Env vars	`EnvVarsFiltered`, `EnvVarsIncluded`
Multi-package	`MultiPackageInstall`, `MultiPackageBuildInfo`
Idempotency	`IdempotentAdd`
Error handling	`ApkBinaryMissing`

`.github/workflows/apkTests.yml`

CI workflow that runs all TestApk* tests against a matrix of Alpine versions (v3.18, v3.19, v3.20, v3.21):

Compiles the test binary on ubuntu-24.04 (where Go 1.26 is available)
Runs the pre-built static binary inside each alpine:<version> Docker container to get a real apk binary
Spins up a local Artifactory instance via install-local-artifactory
Triggered via workflow_call and workflow_dispatch

`scripts/test-apk-local.sh`

Helper script for running Alpine APK e2e tests locally on macOS via Docker (mounts the repo and ~/.jfrog config into a golang:alpine container).

Design Notes

--repo is optional: Consistent with jf npm install and jf pip install, omitting --repo does not block build-info collection. Checksums are always available from the APK database (C: field). AQL enrichment (for SHA-256/MD5) is skipped when no repo is specified.

Test infrastructure: Tests require the apk binary (Alpine Linux). The workflow compiles a static Linux binary on the host and runs it inside Alpine Docker containers, avoiding Go version constraints in Alpine package repos.

AI help coverage: jf apk is wired through corecommon.ResolveDescription to satisfy the TestAIHelpCoverageGenerated check.

github-actions · 2026-07-08T05:53:22Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

- Wire jf apk add/upgrade/upload/update and jf setup apk into the CLI - Add Alpine APK e2e tests: build-info, release-bundle creation, build-promote, arch auto-detect from .PKGINFO, indexable-path layout - Add selective-retry e2e runner script and apk-tools v2/v3 CI matrix - Bump build-info-go, jfrog-cli-core, jfrog-cli-artifactory to Alpine builds Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-07-23T17:40:53Z

🐸 JFrog Frogbot

Consume the Artifactory implementation that validates explicit APK repository selections before execution.

agrasth · 2026-07-27T09:47:20Z

+	} else {
+		serverDetails, err = coreConfig.GetDefaultServerConf()
+		if err != nil {
+			log.Warn("No JFrog server configured — skipping credential injection. Run: jf c add")


coreConfig.GetDefaultServerConf() returns (nil, nil) when no server is configured at all (the common case for a user who hasn't run jf c add), so this err != nil branch won't actually fire there and serverDetails stays nil silently. Worth double-checking what this warning is meant to cover.

agrasth · 2026-07-27T09:47:20Z

+		}
+		cmd := alpinecommand.NewApkCommand(subcmd).
+			SetArgs(filteredArgs).
+			SetServerDetails(serverDetails).


SetServerDetails(serverDetails) is called unconditionally here, even when serverDetails is nil (see the fallback branch above). NixCmd just above (line 2128-2130) guards this with if err == nil && serverDetails != nil. Should ApkCmd follow the same guard for consistency / to avoid passing a nil server details struct downstream?

agrasth · 2026-07-27T09:47:20Z

+                $creds 2>&1 | tee /tmp/apk-out.log
+
+            # Collect the top-level names of tests that failed this attempt.
+            fails=$(grep -Eo '^--- FAIL: [A-Za-z0-9_]+' /tmp/apk-out.log | awk '{print $3}' | sort -u | tr '\n' '|' | sed 's/|$//')


This only checks for literal --- FAIL: lines in the captured output — it doesn't check docker run's own exit code. If the test binary crashes/panics or the container gets OOM-killed before printing any --- FAIL: line, $fails stays empty and the step reports "All Alpine tests passed" on that attempt. Might be worth capturing ${PIPESTATUS[0]} (or splitting the pipe) and treating a non-zero docker exit as a failure too.

agrasth · 2026-07-27T09:47:20Z

+
+// TestApkAdd_ArtifactoryUnreachable verifies that when Artifactory is unreachable
+// jf apk add returns a clear error and does not silently fall back to the public CDN.
+func TestApkAdd_ArtifactoryUnreachable(t *testing.T) {


This test body is identical to TestApkAdd_UnknownServerID above (same --server-id=nonexistent-server-id-xyz args) — it doesn't actually simulate an unreachable Artifactory server, it just re-tests the unknown-server-id path. Should this point at a real unreachable host/port instead (e.g. an invalid URL in a throwaway server config) to cover the case the name describes?

agrasth · 2026-07-27T09:47:20Z

+			depsWithChecksums, len(publishedBuildInfo.BuildInfo.Modules[0].Dependencies))
+		// On a machine with a populated APK cache, checksums should be present.
+		// We assert at least the package itself has one.
+		assert.Greater(t, depsWithChecksums, 0,


This only asserts dep.Sha1 != "" || dep.Sha256 != "" — Md5 is never checked anywhere in this test. Per the checksum requirement (sha256/sha1/md5 all expected), can we add an assertion that at least one dep has a non-empty Md5 too?

agrasth · 2026-07-27T09:47:20Z

+				}
+			}
+		}
+		assert.True(t, hasProd, "at least one dependency should have scope 'prod'")


hasTransitive is computed but only logged at line 468-469, never asserted. Given the comment above says curl reliably brings in transitive deps (libcurl, musl, etc.), should this be assert.True(t, hasTransitive, ...) like the hasProd check right above it, rather than just a log line?

agrasth · 2026-07-27T09:47:20Z

+		}
+		hasTransitiveRequestedBy := false
+		for _, dep := range deps {
+			if len(dep.RequestedBy) > 0 && len(dep.RequestedBy[0]) > 0 {


This only checks that a RequestedBy chain is non-empty, not that its content actually identifies the correct parent (e.g. that libcurl's chain contains curl:<version>). Could tighten this to assert on the actual parent ID rather than just presence.

agrasth · 2026-07-27T09:47:20Z

+	"apk fetch <packages...> [jf-flags]",
+	"apk search <pattern> [jf-flags]",
+	"apk del <packages...>",
+	"apk info [packages...]",


This Usage list (and the subcommand list in GetArguments() below) only documents upload/add/upgrade/update/fetch/search/del/info. apk_test.go's TestApkPassthroughCommands explicitly exercises fix, audit, version, and stats as supported passthrough subcommands — should those be documented here too so jf apk --help reflects everything that's actually supported?

agrasth · 2026-07-27T09:47:20Z

 		BuildName, BuildNumber, module, Project, serverId,
 	},
+	Apk: {
+		serverId, repo, apkAlpineVersion, branch, apkArch, BuildName, BuildNumber, module, Project, user, password,


This reuses the shared branch flag, whose Usage text (line 1855) says "[Mandatory] Branch name to filter.". For jf apk upload, --branch is actually optional and defaults to "main" (per apkUploadSubCmd in buildtools/cli.go). Since this flag's help text is shared across commands, jf apk upload --help will show a misleading "[Mandatory]" for an optional flag — might need a per-command override or a tweaked shared description.

naveenku-jfrog had a problem deploying to build-gate June 19, 2026 20:34 — with GitHub Actions Error

naveenku-jfrog force-pushed the RTECO-alpine branch from 7af2722 to ac81485 Compare June 19, 2026 20:37

naveenku-jfrog had a problem deploying to build-gate June 19, 2026 20:38 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate June 21, 2026 06:56 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate June 21, 2026 07:16 — with GitHub Actions Error

naveenku-jfrog force-pushed the RTECO-alpine branch from 18c3b05 to 89e6093 Compare June 21, 2026 13:54

naveenku-jfrog had a problem deploying to build-gate June 21, 2026 13:54 — with GitHub Actions Error

naveenku-jfrog force-pushed the RTECO-alpine branch from 89e6093 to 7177b09 Compare June 21, 2026 14:07

naveenku-jfrog had a problem deploying to build-gate June 21, 2026 14:08 — with GitHub Actions Error

naveenku-jfrog force-pushed the RTECO-alpine branch from 7177b09 to bcfba32 Compare June 21, 2026 18:02

naveenku-jfrog had a problem deploying to build-gate June 21, 2026 18:02 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate June 21, 2026 20:57 — with GitHub Actions Error

naveenku-jfrog force-pushed the RTECO-alpine branch from ee511cf to dcc6d06 Compare June 21, 2026 21:32

naveenku-jfrog had a problem deploying to build-gate June 21, 2026 21:32 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate June 21, 2026 21:36 — with GitHub Actions Error

naveenku-jfrog force-pushed the RTECO-alpine branch from 7f9c899 to 213f8f6 Compare June 23, 2026 06:14

naveenku-jfrog had a problem deploying to build-gate June 23, 2026 06:14 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 7, 2026 04:00 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 7, 2026 04:26 — with GitHub Actions Error

naveenku-jfrog force-pushed the RTECO-alpine branch from 0214c4f to 98397ae Compare July 7, 2026 05:19

naveenku-jfrog had a problem deploying to build-gate July 7, 2026 05:19 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 7, 2026 10:09 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 8, 2026 05:53 — with GitHub Actions Error

naveenku-jfrog temporarily deployed to build-gate July 8, 2026 05:53 — with GitHub Actions Inactive

naveenku-jfrog had a problem deploying to build-gate July 8, 2026 06:04 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 8, 2026 06:10 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 8, 2026 09:37 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 13, 2026 04:08 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 13, 2026 04:09 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 14, 2026 06:01 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 14, 2026 06:09 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 14, 2026 06:33 — with GitHub Actions Error

naveenku-jfrog temporarily deployed to build-gate July 14, 2026 06:59 — with GitHub Actions Inactive

naveenku-jfrog temporarily deployed to build-gate July 14, 2026 08:26 — with GitHub Actions Inactive

naveenku-jfrog had a problem deploying to build-gate July 14, 2026 08:35 — with GitHub Actions Error

naveenku-jfrog changed the title ~~Rteco alpine~~ RTECO-945: Wire jf apk commands and e2e tests Jul 14, 2026

naveenku-jfrog force-pushed the RTECO-alpine branch from 1a9f22a to 0277d99 Compare July 14, 2026 09:19

naveenku-jfrog temporarily deployed to build-gate July 14, 2026 09:19 — with GitHub Actions Inactive

naveenku-jfrog had a problem deploying to build-gate July 17, 2026 17:36 — with GitHub Actions Error

naveenku-jfrog mentioned this pull request Jul 17, 2026

RTECO-945: Add Apk to ProjectType enum for jf setup apk support jfrog/jfrog-cli-core#1584

Open

4 tasks

naveenku-jfrog had a problem deploying to build-gate July 17, 2026 17:50 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 17, 2026 18:07 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 17, 2026 18:10 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 17, 2026 18:13 — with GitHub Actions Error

naveenku-jfrog force-pushed the RTECO-alpine branch from b994bb9 to c488334 Compare July 17, 2026 19:05

naveenku-jfrog temporarily deployed to build-gate July 17, 2026 19:06 — with GitHub Actions Inactive

naveenku-jfrog had a problem deploying to build-gate July 19, 2026 15:20 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 19, 2026 15:24 — with GitHub Actions Error

naveenku-jfrog force-pushed the RTECO-alpine branch from 8c534d2 to a0db8ca Compare July 19, 2026 15:27

naveenku-jfrog had a problem deploying to build-gate July 19, 2026 15:27 — with GitHub Actions Error

naveenku-jfrog force-pushed the RTECO-alpine branch from a0db8ca to db5e2a4 Compare July 19, 2026 15:29

naveenku-jfrog temporarily deployed to build-gate July 19, 2026 15:29 — with GitHub Actions Inactive

naveenku-jfrog had a problem deploying to build-gate July 20, 2026 04:32 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 20, 2026 05:12 — with GitHub Actions Error

naveenku-jfrog had a problem deploying to build-gate July 20, 2026 05:14 — with GitHub Actions Error

RTECO-945: Update Alpine repository validation

10f5348

Consume the Artifactory implementation that validates explicit APK repository selections before execution.

agrasth reviewed Jul 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RTECO-945: Wire jf apk commands and e2e tests - #3561

RTECO-945: Wire jf apk commands and e2e tests#3561
naveenku-jfrog wants to merge 2 commits into
masterfrom
RTECO-alpine

naveenku-jfrog commented Jun 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 8, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

agrasth Jul 27, 2026

Uh oh!

agrasth Jul 27, 2026

Uh oh!

agrasth Jul 27, 2026

Uh oh!

agrasth Jul 27, 2026

Uh oh!

agrasth Jul 27, 2026

Uh oh!

agrasth Jul 27, 2026

Uh oh!

agrasth Jul 27, 2026

Uh oh!

agrasth Jul 27, 2026

Uh oh!

agrasth Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

naveenku-jfrog commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

buildtools/cli.go

utils/cliutils/commandsflags.go

docs/buildtools/apkcommand/help.go

packagealias/packagealias.go

apk_test.go

.github/workflows/apkTests.yml

scripts/test-apk-local.sh

Design Notes

Uh oh!

github-actions Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

naveenku-jfrog commented Jun 19, 2026 •

edited

Loading

`buildtools/cli.go`

`utils/cliutils/commandsflags.go`

`docs/buildtools/apkcommand/help.go`

`packagealias/packagealias.go`

`apk_test.go`

`.github/workflows/apkTests.yml`

`scripts/test-apk-local.sh`

github-actions Bot commented Jul 8, 2026 •

edited

Loading