WKS-2860 - Support clear-text worker properties in the CLI - #63
Merged
Merged
Conversation
Contributor
RemiBou
approved these changes
Sep 22, 2026
| commands.GetRemoveCommand(), | ||
| commands.GetListCommand(), | ||
| commands.GetAddSecretCommand(), | ||
| commands.GetAddPropertyCommand(), |
Collaborator
There was a problem hiding this comment.
why do we need a new command and not set them directly on the manifest ? like for filter
Collaborator
Author
There was a problem hiding this comment.
Similar behaviour as secret, maybe useful for automation or if you dont want to trifle with the manifest syntax.
vitaliil-jfrog
approved these changes
Sep 23, 2026
Let users declare properties in the manifest and add-property, then send them on deploy and test-run without encryption. Omitting the field leaves remote properties unchanged; an empty object clears them.
worker-qa must expose the same command as jf worker so QA can run add-property.
Also log the requested worker key in FetchWorkerDetails, since details.Key is not yet populated before unmarshalling.
ehl-jf
force-pushed
the
WKS-2860-cli-clear-text-worker-properties
branch
from
October 1, 2026 09:01
4085f06 to
2c883ba
Compare
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let users declare properties in the manifest and add-property, then send them on deploy and test-run without encryption. Omitting the field leaves remote properties unchanged; an empty object clears them.
mainbranch.go vet ./....go fmt ./....