AX-1847 Moving from session start hook to skills (skills sync in from jfrog-skills) - #43
Open
MatanEden1 wants to merge 5 commits into
Open
AX-1847 Moving from session start hook to skills (skills sync in from jfrog-skills)#43MatanEden1 wants to merge 5 commits into
MatanEden1 wants to merge 5 commits into
Conversation
… jfrog-skills) Retires the legacy sessionStart hook that force-injected the ~440-line MCP-management template into every session. JFrog MCP management now lives in discoverable skills that sync in from jfrog/jfrog-skills, so this removes the hook machinery and the hand-maintained template to avoid a second source of truth. Removed: - plugins/jfrog/hooks/hooks.json — the sessionStart hook definition - plugins/jfrog/scripts/inject-instructions.mjs — the injector - plugins/jfrog/templates/jfrog-mcp-management.md — the always-on template - scripts/validate-hook-injector.mjs — the injector validator - .github/workflows/validate-inject-instructions.yml — CI for the injector Also dropped the now-unused "hooks" key from the plugin manifest and cleaned up the residual hook references in the READMEs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The sessionStart hook was retired in favor of skills, but three README references still described Agent Guard as a "Hook": - README.md capabilities table: relabel the Agent Guard row Hook -> Skill - plugins/jfrog/README.md: drop "hook" from the JFrog CLI prerequisite Completes the README cleanup listed in the PR description / test plan. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MatanEden1
force-pushed
the
AX-1847-move-to-skills
branch
from
July 26, 2026 06:04
b4814a1 to
731f533
Compare
Cursor skips re-installing/updating a plugin whose resolved version hasn't changed (see VENDOR.md). The hook->skills change alters plugin.json's manifest and hook wiring, so it needs a version bump for existing installs to pick it up.
Ports the harness-agnostic jfrog-mcp-management skill from jfrog-skills (feature/AX-1777-jfrog-mcp-skills) plus fixes found during the AX-1777 bug hunt (see Confluence "BUG hunt - Jfrog mcp skill"), including the Cursor "multiple/no JFrog server configured" case: the troubleshooting entry now points at the existing isDefault-based resolution chain in agent-guard-common.md instead of just saying "pass --server <ID>" with no guidance on picking one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
YoniMelki
requested changes
Jul 26, 2026
YoniMelki
left a comment
YoniMelki
left a comment
Collaborator
There was a problem hiding this comment.
This PR shouldn't have the skills folder. It should be done from the Skills' CI
This skill is vendored from jfrog/jfrog-skills via the sync process and should not be hand-committed here.
MatanEden1
force-pushed
the
AX-1847-move-to-skills
branch
from
July 28, 2026 06:57
b9a991f to
534a0e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retires the legacy
sessionStarthook that force-injected a ~440-line MCP-management template into every session. JFrog MCP management now lives in discoverable skills that are vendored in via sync fromjfrog/jfrog-skillsrather than driven by a hand-maintained hook + template — so this branch removes the hook machinery to avoid a second source of truth.Mirrors the equivalent change in
jfrog/claude-plugin#33.Net change vs
main(pure removal)plugins/jfrog/hooks/hooks.json— thesessionStarthook definitionplugins/jfrog/scripts/inject-instructions.mjs— the injector that force-fed the templateplugins/jfrog/templates/jfrog-mcp-management.md— the always-on templatescripts/validate-hook-injector.mjs— its validator.github/workflows/validate-inject-instructions.yml— CI for the injectorplugins/jfrog/.cursor-plugin/plugin.json— dropped the now-unused"hooks"keyREADME.md/plugins/jfrog/README.md— removed dangling hook references; Node bumped to ≥ 18The
validate-template.mjsgeneral manifest validator and itsvalidate-template.ymlworkflow are kept — they are not hook-specific.Where the skills live now
The JFrog MCP skills + their shared references arrive in this plugin through the vendored sync from
jfrog/jfrog-skills, not by hand-committing them here.Test plan
node scripts/validate-template.mjspasses.🤖 Generated with Claude Code