Skip to content

chore(build): exclude patchedDependencies from target pnpm workspace #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paustint wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

chore(build): exclude patchedDependencies from target pnpm workspace #1980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/build-electron.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,11 @@ function prepareTargetPackageJson() {
// Inherit root pnpm-workspace.yaml settings but reset `packages` to an empty list so
// TARGET_DIR becomes a self-contained workspace root with no nested member packages.
// This isolates the subsequent `pnpm add` calls from the parent repo's workspace/lockfile.
const targetWorkspace = { ...rootWorkspace, packages: [] };
writeFileSync(TARGET_PNPM_WORKSPACE_PATH, dumpYaml(targetWorkspace));
// Drop `patchedDependencies` too: it points at files under the root `patches/` directory,
// which isn't copied into TARGET_DIR, and the patched packages (e.g. dev-only lint tooling)
// aren't part of the desktop build's dependency set anyway.
const { patchedDependencies, ...targetWorkspace } = rootWorkspace;
writeFileSync(TARGET_PNPM_WORKSPACE_PATH, dumpYaml({ ...targetWorkspace, packages: [] }));
}

async function build() {
Expand Down
Loading