add _lastModifiedTime field to secret snapshots#810
Open
EldarShalev wants to merge 4 commits into
Open
Conversation
Extract the most recent time from metadata.managedFields and include it as a synthetic _lastModifiedTime field on Secret objects sent to the backend. This enables detection of stale or unrotated secrets.
SgtCoDFish
reviewed
May 26, 2026
| } | ||
| } | ||
|
|
||
| setLastModifiedTime(resource) |
Contributor
There was a problem hiding this comment.
suggestion: this unilaterally sets the last modified time in all cases. This repo contains 3 agents which we release, and this change is only for the disco-agent and not the others. I think we'd need to change this PR so it only affects the disco agent.
SgtCoDFish
reviewed
May 26, 2026
Comment on lines
+643
to
+645
| if timeVal > latestTime { | ||
| latestTime = timeVal | ||
| } |
Contributor
There was a problem hiding this comment.
suggestion: treating the values as strings means that Go will compare lexicographically, not by the times represented.
It should be possible to write a test case which detects the wrong latestTime based on this comparison. You'll have to parse the timestamps into time.Time values to compare them safely + properly.
added 2 commits
May 26, 2026 19:23
…e' into feature/secret-last-modified-time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the most recent time from metadata.managedFields and include it as a synthetic _lastModifiedTime field on Secret objects sent to the backend. This enables detection of stale or unrotated secrets.