Skip to content

Add the option to turn off automatic redirect handling - #124

Open
g-host-one wants to merge 4 commits into
jenkinsci:masterfrom
g-host-one:follow_redirects
Open

g-host-one wants to merge 4 commits into
jenkinsci:masterfrom
g-host-one:follow_redirects

Conversation

@g-host-one

Copy link
Copy Markdown

Added the option followRedirects to turn off automatic redirect handling.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@g-host-one
g-host-one requested a review from a team as a code owner November 20, 2022 11:54
@jimklimov

Copy link
Copy Markdown
Contributor

Looks decent, but I'm not a team member (yet?..) :)

CI fault is with infra:

[2022-11-20T12:13:36.420Z] Publishing Coverage report....
[2022-11-20T12:13:37.922Z] A total of 1 reports were found
[2022-11-20T12:13:37.966Z] Report coverage diff: 0.0%. Add to CoverageResult.
[2022-11-20T12:13:37.966Z] Group coverage diff: 0.0%. Add to CoverageResult.
[2022-11-20T12:13:37.966Z] Package coverage diff: 0.0%. Add to CoverageResult.
[2022-11-20T12:13:37.966Z] File coverage diff: 0.0%. Add to CoverageResult.
[2022-11-20T12:13:37.966Z] Class coverage diff: 0.0%. Add to CoverageResult.
[2022-11-20T12:13:37.966Z] Method coverage diff: 0.22542572%. Add to CoverageResult.
[2022-11-20T12:13:37.966Z] Instruction coverage diff: 0.14528656%. Add to CoverageResult.
[2022-11-20T12:13:37.966Z] Line coverage diff: 0.21066284%. Add to CoverageResult.
[2022-11-20T12:13:37.966Z] Conditional coverage diff: 0.169487%. Add to CoverageResult.
[2022-11-20T12:13:37.966Z] [Coverage] Computing coverage delta report
[2022-11-20T12:13:37.966Z] [Coverage] Obtaining reference build from reference recorder
[2022-11-20T12:13:37.966Z] [Coverage] -> Found 'Plugins » http-request-plugin » master #114'
[2022-11-20T12:13:37.966Z] [Coverage] -> Using reference build 'Plugins/http-request-plugin/master #114'
[2022-11-20T12:13:37.966Z] [Coverage] -> Found reference result 'io.jenkins.plugins.coverage.CoverageAction@261814df'
[2022-11-20T12:13:38.409Z] using credential app-ci.jenkins.io
[2022-11-20T12:13:38.892Z] using credential app-ci.jenkins.io
java.util.concurrent.ExecutionException: Invalid object ID 62 iota=66

At dayjob, we had some (cucumber?) publishing issues so ended up using a lockable resource so one report is published at a time...

@h3nr1-d14z

Copy link
Copy Markdown
Contributor

triage pass: this feature is still missing on master — the redirect strategy is always wired in (restricted to GET/HEAD since #229), there's no opt-out. the ask is still valid.

the bad news is the PR predates the HttpClient 5 migration (#197) and doesn't apply cleanly anymore. if you're still around and want to rebase, go ahead. otherwise I'm happy to port it onto current master with you credited — just say something in the next couple of weeks so I know you're interested.

— h3nr1-d14z

@g-host-one

Copy link
Copy Markdown
Author

Thanks for the update and for taking the time to look into this! I’ll review the current state this week and get back to you.

# Conflicts:
#	src/main/java/jenkins/plugins/http_request/HttpRequest.java
#	src/main/java/jenkins/plugins/http_request/HttpRequestExecution.java
#	src/main/java/jenkins/plugins/http_request/HttpRequestStep.java
#	src/test/java/jenkins/plugins/http_request/HttpRequestTest.java
#	src/test/java/jenkins/plugins/http_request/Registers.java
@g-host-one

Copy link
Copy Markdown
Author

@h3nr1-d14z I’ve rebased the PR onto the current master, and all tests are passing. The PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants