Skip to content

Version every SRI-pinned script URL by its own hash #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdevalk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Version every SRI-pinned script URL by its own hash #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions functions/admin/stats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,17 @@ const AGENT = "sw_agent_log";
const MCP = "sw_mcp_log";
const REPORT = "sw_report_log";

// SRI for /admin-stats.js. Hardcoded (this is an edge Function, not an Astro
// render); scripts/check-integrity.mjs verifies it matches public/admin-stats.js
// on every build.
const ADMIN_STATS_SRI =
"sha384-XUWxtbHAb/brkCdgXgjE9OLsRhBFCUFd5U2oRGnojav+W3oVhEbH80w/ji0pEn44";

/** Cache-busting slice of an SRI hash; mirrors hashVersion() in src/lib/integrity.ts. */
function hashVersion(integrity: string): string {
return integrity.slice(7, 19).replace(/[^A-Za-z0-9]/g, "_");
}

// Include direct .md URLs and the legacy Accept-header flag in historical data.
const AGENT_MARKDOWN = "(blob10 IN ('markdown', '1') OR blob4 LIKE '%.md')";
const AGENT_MIME = `if(${AGENT_MARKDOWN}, 'markdown', 'html')`;
Expand Down Expand Up @@ -938,10 +949,9 @@ function renderDashboard(
</div>
</div>

<!-- SRI so this satisfies Integrity-Policy. Hardcoded (this is an edge
Function, not an Astro render); scripts/check-integrity.mjs verifies it
matches public/admin-stats.js on every build. -->
<script src="/admin-stats.js" defer integrity="sha384-XUWxtbHAb/brkCdgXgjE9OLsRhBFCUFd5U2oRGnojav+W3oVhEbH80w/ji0pEn44" crossorigin="anonymous"></script>
<!-- SRI so this satisfies Integrity-Policy; the URL carries a slice of it so
a deploy can't collide with a stale cached copy. See ADMIN_STATS_SRI. -->
<script src="/admin-stats.js?v=${hashVersion(ADMIN_STATS_SRI)}" defer integrity="${ADMIN_STATS_SRI}" crossorigin="anonymous"></script>
</body>
</html>`;
}
Loading
Loading