feat: Add system and system_action to WebhookMergeRequestEventSchema#3847
Open
kang8 wants to merge 1 commit into
Open
feat: Add system and system_action to WebhookMergeRequestEventSchema#3847kang8 wants to merge 1 commit into
kang8 wants to merge 1 commit into
Conversation
GitLab merge request webhooks include object_attributes.system (always present) and object_attributes.system_action (present only on system-initiated events, e.g. approval resets on push), but neither was declared on WebhookMergeRequestEventSchema. Add both; system mirrors the existing system: boolean in the note webhook schemas, and system_action is a documented two-value union. Ref: https://docs.gitlab.com/user/project/integrations/webhook_events/#merge-request-events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitLab merge request webhooks include
object_attributes.system(always present) andobject_attributes.system_action(present only on system-initiated events, e.g. approval resets on push), but neither is declared onWebhookMergeRequestEventSchema. This PR adds both.system: booleanmirrors the existingsystem: booleanalready present in the note webhook schemas.system_action?is an optional, documented two-value union (approvals_reset_on_push|code_owner_approvals_reset_on_push), exposed as an exportedMergeRequestSystemActiontype mirroring the neighbouringReviewerStatetype.Ref: GitLab webhook events — merge request events