Skip to content

Added alternative example#20

Open
julkue wants to merge 1 commit into
jbr:masterfrom
julkue:demo-alternative
Open

Added alternative example#20
julkue wants to merge 1 commit into
jbr:masterfrom
julkue:demo-alternative

Conversation

@julkue

@julkue julkue commented May 21, 2016

Copy link
Copy Markdown

Here you go.
Closes #19

@julkue

julkue commented Jul 19, 2016

Copy link
Copy Markdown
Author

Ping @jbr

@jbr

jbr commented Jul 19, 2016

Copy link
Copy Markdown
Owner

@julmot What improvement over the existing demo does the codepen demo offer? Could the existing demo be improved or replaced?

@jbr

jbr commented Jul 19, 2016

Copy link
Copy Markdown
Owner

I would happily accept changes to https://github.com/jbr/jQuery.highlightRegex/blob/master/index.html if there are features that would improve it

@julkue

julkue commented Jul 19, 2016

Copy link
Copy Markdown
Author

Feel free to PR a link to that url to the README

what's wrong now?

@julkue

julkue commented Jul 19, 2016

Copy link
Copy Markdown
Author
  1. It is responsive
  2. It is colorized
  3. It allows users to enter custom modifiers
  4. It allows users to specify custom options

@jbr

jbr commented Jul 19, 2016

Copy link
Copy Markdown
Owner

I realized there was no reason to have two similar examples. I'd like to replace index.html with something like yours, if you think those four improvements would help people get a sense of the plugin.

@julkue

julkue commented Jul 20, 2016

Copy link
Copy Markdown
Author

Well, I think both examples give a quick overview and beside of more options the CodePen demo offers a better UX.
So the choice is yours 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants