Avoid static destructors during program exit - #1471
Open
jwnimmer-tri wants to merge 1 commit into
Open
Conversation
Function-local static variables must either be marked constexpr or never_destroyed. Otherwise, their order of destruction during program exit is indeterminate and can lead to undefined behavior.
jwnimmer-tri
force-pushed
the
never_destroyed
branch
from
July 27, 2026 15:03
52c6114 to
7d639ab
Compare
SGSSGene
reviewed
Jul 30, 2026
SGSSGene
left a comment
SGSSGene
left a comment
Collaborator
There was a problem hiding this comment.
I think this PR needs some discussion.
What I understand is:
The extra never_destroyed template makes the data types "leak" their data on the heap by not calling delete and by this avoid wrong destruction order.
I think this is quiet some source code overhead. It avoid a theoretical issue that does not occur during execution and it will (hopefully) trigger memory leak detection (address sanitizer or valgrind).
So I am positioning myself against this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function-local static variables must either be marked constexpr or never_destroyed. Otherwise, their order of destruction during program exit is indeterminate and can lead to undefined behavior.
https://en.cppreference.com/cpp/language/siof
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables