Skip to content

Fix Sonar S2259 potential NPEs to restore reliability rating (#231) #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasIgel merged 1 commit into from
Aug 6, 2026
Merged

Fix Sonar S2259 potential NPEs to restore reliability rating (#231) #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ssor/src/main/java/org/javahelpers/simple/builders/processor/analysis/JavaLangMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,8 @@ protected TypeName defaultAction(TypeMirror e, Void p) {
* @return true if it's a concrete class
*/
private static boolean isConcreteClass(TypeElement typeElement) {
return typeElement.getKind() == javax.lang.model.element.ElementKind.CLASS
return typeElement != null
&& typeElement.getKind() == javax.lang.model.element.ElementKind.CLASS
&& !typeElement.getModifiers().contains(javax.lang.model.element.Modifier.ABSTRACT);
}
}
9 changes: 6 additions & 3 deletions processor/src/main/java/org/javahelpers/simple/builders/processor/util/ImportCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import java.util.Comparator;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Set;
import java.util.stream.Collectors;
import org.apache.commons.lang3.StringUtils;
Expand All @@ -15,6 +16,7 @@
import org.javahelpers.simple.builders.processor.model.method.MethodCodeTypePlaceholder;
import org.javahelpers.simple.builders.processor.model.method.MethodDto;
import org.javahelpers.simple.builders.processor.model.method.MethodParameterDto;
import org.javahelpers.simple.builders.processor.model.type.GenericParameterDto;
import org.javahelpers.simple.builders.processor.model.type.TypeName;
import org.javahelpers.simple.builders.processor.model.type.TypeNameArray;
import org.javahelpers.simple.builders.processor.model.type.TypeNameGeneric;
Expand Down Expand Up @@ -147,9 +149,10 @@ public ImportCollector collectImports(GenerationTargetClassDto classDef) {

// Add class type and generics
addTypeImports(classDef.getTypeName());
classDef
.getGenerics()
.forEach(generic -> generic.getUpperBounds().forEach(this::addTypeImports));
List<GenericParameterDto> generics = classDef.getGenerics();
if (generics != null) {
generics.forEach(generic -> generic.getUpperBounds().forEach(this::addTypeImports));
}

// Add interface imports
classDef.getInterfaces().forEach(this::addInterfaceImports);
Expand Down
Loading