Skip to content

Checking PR Decoration pipelines #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasIgel wants to merge 15 commits into from
Closed

Checking PR Decoration pipelines #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
32714e4
Adding sonar-maven-plugin to pluginManagement to have short usages (s…
AndreasIgel Jan 25, 2026
95f86e4
Optimization of action configuration
AndreasIgel Jan 25, 2026
f17e6cb
Optimization of sonarQube configuration via pom.xml properties
AndreasIgel Jan 25, 2026
5147b20
Removing focus to primefaces-repository, because need to check it in …
AndreasIgel Jan 25, 2026
4f00703
Removing more conditions on repository
AndreasIgel Jan 25, 2026
6145f1f
Adepting if-condition and extending command to have sonar-pullrequest…
AndreasIgel Jan 25, 2026
76bc23a
Modifying integration tests to run only for onw
AndreasIgel Jan 25, 2026
4143c44
Extending logging to verify what is going wrong
AndreasIgel Jan 25, 2026
342750e
Cancel on java 11 builds for easier debugging
AndreasIgel Jan 25, 2026
1be5ba9
Undoing changes, which have been done for debugging
AndreasIgel Jan 25, 2026
8b6a96c
Reenabling checks, which are specific for primefaces-repository
AndreasIgel Jan 25, 2026
7eca8af
Disabling sonar scanning for dependabot (this kind of actions do not …
AndreasIgel Jan 25, 2026
9918715
Adding condition for pull-requests (github.ref is for merge-backs of …
AndreasIgel Jan 25, 2026
6b5445b
Fixing project key (missed on switching back to primefaces)
AndreasIgel Jan 25, 2026
01c2726
Updating to latest version of sonar-maven-plugin
AndreasIgel Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
java: [11, 25]
steps:
- uses: actions/checkout@v6
with:
fetch-depth: 0 # SonarQube needs full git history
- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v5
with:
Expand All @@ -34,12 +36,12 @@ jobs:
- name: Build
run: mvn clean install -T1C -Pminify --batch-mode --show-version
- name: Sonar Cloud
if: github.repository == 'primefaces/primefaces' && github.ref == 'refs/heads/master' && matrix.java == 25
run: mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent install org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Pquick -Dsonar.organization=primefaces -Dsonar.host.url=https://sonarcloud.io -Dsonar.token=${{secrets.SONAR_TOKEN}} -fprimefaces/pom.xml
if: github.repository == 'primefaces/primefaces' && (github.ref == 'refs/heads/master' || github.event_name == 'pull_request') && matrix.java == 25 && github.actor != 'dependabot[bot]'
run: mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent install org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Pquick --file primefaces/pom.xml
# new approach with code-coverage does not work as of 2024/12 because
# "Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:4.0.0.4121:sonar (default-cli) on project primefaces-parent: Could not find a default branch for project with key 'org.primefaces:primefaces-parent'. Make sure project exists. -> [Help 1]"
# setting sonar.skip=true in the parent-pom.xml does not work either because this results in skipping the whole project, setting sonar.skip=false for modules does not compensate for this
# run: mvn clean install sonar:sonar -Pintegration-tests,parallel-execution,headless,chrome,theme-saga,csp,mojarra-4.0 -Dsonar.organization=primefaces -Dsonar.host.url=https://sonarcloud.io -Dsonar.token=${{secrets.SONAR_TOKEN}}
# run: mvn clean install sonar:sonar -Pintegration-tests,parallel-execution,headless,chrome,theme-saga,csp,mojarra-4.0 -Dsonar.organization=primefaces -Dsonar.host.url=https://sonarcloud.io -Dsonar.token=******
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand Down
6 changes: 5 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
<slf4j.version>2.0.17</slf4j.version>

<sonar.skip>true</sonar.skip>
<sonar.coverage.jacoco.xmlReportPaths>../primefaces-coverage/target/site/jacoco-aggregate/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>

<npm.token/>
<npm.username/>
Expand Down Expand Up @@ -151,6 +150,11 @@
<artifactId>maven-shade-plugin</artifactId>
<version>3.6.1</version>
</plugin>
<plugin>
<groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId>
<version>5.5.0.6356</version>
</plugin>
</plugins>
</pluginManagement>
<plugins>
Expand Down
7 changes: 7 additions & 0 deletions primefaces/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,14 @@
<yarn.version>v1.22.22</yarn.version>
<frontend.directory>${basedir}/src/main/frontend</frontend.directory>
<frontend.node.env>development</frontend.node.env>

<!-- SonarQube configuration -->
<sonar.skip>false</sonar.skip>
<sonar.projectKey>org.primefaces:primefaces</sonar.projectKey>
<sonar.projectName>PrimeFaces</sonar.projectName>
<sonar.organization>org.primefaces</sonar.organization>
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
<sonar.coverage.jacoco.xmlReportPaths>../primefaces-coverage/target/site/jacoco-aggregate/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>
</properties>

<dependencies>
Expand Down