Add missing override specifiers - #3888
Open
softins wants to merge 1 commit into
Open
Conversation
Satisfies compiler warnings on macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Add missing override specifiers to satisfy compiler warnings on macOS
CHANGELOG: Added missing override specifiers for virtual methods
Context: Fixes an issue?
This is similar to #3667. A couple of new ones showed up while compiling on macOS. I think they surfaced
due to adding the event filter in #3859, which was itself an override.
This change adds the missing override specifiers, but does not change any functionality.
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready
What is missing until this pull request can be merged?
Nothing
Checklist