Fix realtime audio engine failures and teardown stalls on macOS - #196
Merged
Conversation
jamesrochabrun
commented
Aug 11, 2026
jamesrochabrun
commented
Owner
- Build the playback graph before enabling voice processing: enabling VP first leaves AVAudioEngine unable to initialize (-10875).
- Route the player through mainMixerNode: connecting 24 kHz mono straight into the output node fails AUGraph init on mismatched hardware formats.
- Expose isPlaybackActive so clients can gate their microphone while assistant audio is audibly playing (half-duplex echo suppression).
- Stop disabling voice processing in the capture vendor's stop(): the engine is single-use, and the call blocks on default-QoS CoreAudio work, tripping priority-inversion diagnostics.
- Build the playback graph before enabling voice processing: enabling VP first leaves AVAudioEngine unable to initialize (-10875). - Route the player through mainMixerNode: connecting 24 kHz mono straight into the output node fails AUGraph init on mismatched hardware formats. - Expose isPlaybackActive so clients can gate their microphone while assistant audio is audibly playing (half-duplex echo suppression). - Stop disabling voice processing in the capture vendor's stop(): the engine is single-use, and the call blocks on default-QoS CoreAudio work, tripping priority-inversion diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.