Add test coverage for ExtractLongStringPrompt fallback path in ComfyUIParameterDecoder - #539
Merged
jamesmoore merged 2 commits intoAug 15, 2026
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment 3788774555
Add test coverage for ExtractLongStringPrompt fallback path in ComfyUIParameterDecoder
Aug 15, 2026
jamesmoore
marked this pull request as ready for review
August 15, 2026 07:12
jamesmoore
approved these changes
Aug 15, 2026
…rDecoderTest Co-authored-by: jamesmoore <6506748+jamesmoore@users.noreply.github.com>
jamesmoore
force-pushed
the
copilot/fix-review-comment-538
branch
from
August 15, 2026 07:14
d04e074 to
c89dd7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ExtractLongStringPromptfallback (used when CLIP node extraction yields no prompt) had no test coverage, leaving it unprotected against regressions.Changes
GetParams_FallsBackToExtractLongStringPrompt_WhenNoClipNodes— exercises the fallback path using a workflow with noCLIPTextEncodenodes but a long string value (>100 chars) embedded in a custom node's inputstestJsonWithLongStringFallback— minimal ComfyUI workflow JSON that bypasses CLIP-based extraction and forces theExtractLongStringPromptcode path