fix(ws): auto-ack notification hooks (status/conference events)#13
Merged
Conversation
…s events verb:hook messages are delivered to the app's path listener and the SDK then waited for the app to reply() — fine for action hooks (the reply carries verbs), but conference/status events (start, join, leave, say-start/done, play-start/done) are observational: an app that just watches them never replies, so each one timed out far-end (~5s) and logged noise. Auto-ack verb:hook notifications (identified by data.event, the jambonz status-event marker) right after emitting to the listener. Action hooks (no data.event) are unchanged — the app still owns the reply. Adds session message-handling tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conference/status
verb:hookevents (start, join, leave, say-start/done, play-start/done) are observational — an app that registers asession.on('/room-status', …)listener to watch them neverreply()s, so each event timed out far-end (~5s) on the feature-server and logged noise (seen across a room-say live test: every status event →timeout from far end for msgid …).The SDK delivers
verb:hookto the listener and then waits for the app to reply (correct for action hooks, whose reply carries verbs). This change auto-acks notification hooks — identified bydata.event(the jambonz status-event marker) — immediately after emitting to the listener. Action hooks (nodata.event) are unchanged: the app still owns the reply.Adds the first session message-handling tests (notification auto-acks; action hook does not; no-listener unchanged). Full suite 120 green.
🤖 Generated with Claude Code