Add lint and type checking, update APNs client to current Apple spec - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tooling (pyproject.toml + CI)
ruff check,ruff format --check, andmypyalongside pytest, with setup-python v5 and pip cachingCode improvements from lint findings
__init__.pythat made the repo a pseudo-package (broke mypy and ruff module resolution)DeviceEntityconverted to SQLAlchemy 2.0 typedMapped/mapped_columnstyle__all__re-exports in all packages; snake_case dependency parameters; f-strings over%-formatting; stale# type:comments replaced with real annotationsAPNs client updated to Apple's current spec
Reviewed against Apple's current provider API and error docs:
api.development.push.apple.com→ the documentedapi.sandbox.push.apple.com(verified live against Apple's sandbox)ExpiredToken(410) now prunes devices likeUnregistered— Apple's newer second "token is dead" reason was previously ignored, so expired tokens would be re-pushed foreverInvalidPushType,BadEnvironmentKeyIdInToken,UnrelatedKeyIdInTokenexceptions andliveactivity/pushtotalk/location/widgets/controlspush-type inferenceTest plan
InvalidProviderTokenreturned for the throwaway test key