Skip to content

Require valid states for SPECTRE physical losses#496

Open
krystophny wants to merge 1 commit into
agent/liberal-generic-newton-cleanfrom
agent/spectre-valid-crossings-clean
Open

Require valid states for SPECTRE physical losses#496
krystophny wants to merge 1 commit into
agent/liberal-generic-newton-cleanfrom
agent/spectre-valid-crossings-clean

Conversation

@krystophny

Copy link
Copy Markdown
Member

Prevents numerical failures or non-finite interface states from becoming physical loss events.

  • only OUTSIDE_DOMAIN can seed an outer-boundary landing
  • validate landed coordinates, momentum, pitch, B, mu, and refraction radicand
  • return CROSS_INVALID and roll back into recovery instead of logging a loss
  • apply the same validity contract to RK SPECTRE stepping
  • adversarial NaN and invalid-momentum tests

The complete stacked branch passes the full fo static, build, test, and lint pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant