fix(cloudflare,netskope): fix schema bugs blocking Integration Model import - #100
Merged
Merged
Conversation
…odel import
Found by actually importing both specs into a live Itential Platform
instance (they had never been tested end-to-end before):
- Cloudflare curated spec: several schemas used the Draft-04/Swagger 2.0
boolean exclusiveMinimum form (paired with a separate minimum key),
which OpenAPI 3.0 requires as a single numeric exclusiveMinimum value.
Fixed 20 occurrences.
- Netskope curated + full specs: two paths shared the same operationId
(RolesController_getRole on /platform/roles/{role_id} and
/rbac/roles/{rid}) — Itential Platform rejects duplicate operation IDs
on import. Disambiguated the RBAC one. Also fixed one path parameter
({feature} on DELETE /platform/admin/preferences/{page}/{feature})
incorrectly marked required: false — OpenAPI 3.0 requires all path
parameters to be required: true.
All three specs now import successfully.
Same class of violation caught in NDFC (PR #98): full-spec filenames didn't match info.version (cloudflare_v4.json -> cloudflare-4.0.0.json, netskope_v2.json -> netskope-1.0.0.json), -latest specs kept the real vendor version in info.version instead of "latest" (now preserved in x-vendor-api-version), and both titles carried a redundant "API"/"REST API" suffix. Confirmed both curated specs still import cleanly with the corrected identity (Cloudflare:latest, Netskope:latest).
…ubset Cloudflare: 29 workflows across 6 folders (DNS records, zones, firewall rules, load balancers, workers, access applications). Netskope: 24 workflows across 5 folders (real-time policy, SCIM users/groups, URL lists, RBAC roles). Built locally, one atomic workflow per operation, not yet imported/tested against a live platform instance.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both specs had never actually been imported into a live Itential Platform instance before merging — testing that surfaced real bugs in both, plus the same filename/version convention gap already found and fixed for NDFC in #98. Also adds the Studio Projects that should have shipped with the original PRs.
Import-blocking bugs
Cloudflare (
cloudflare-latest.json): 20 schemas used the Draft-04/Swagger 2.0 booleanexclusiveMinimumform (e.g."exclusiveMinimum": true, "minimum": 0). OpenAPI 3.0 requires this as a single numeric value ("exclusiveMinimum": 0). Platform's AJV validation rejected the import outright. Fixed all 20 occurrences.Netskope (
netskope-latest.json, full spec):RolesController_getRole(/platform/roles/{role_id}and/rbac/roles/{rid}) — Itential Platform rejects duplicate operation IDs. Renamed the RBAC one toRbacRolesController_getRole.DELETE /platform/admin/preferences/{page}/{feature}had its{feature}path parameter markedrequired: false— OpenAPI 3.0 requires allin: pathparameters to berequired: true. Fixed.Convention fixes (same class as #98)
info.version:cloudflare_v4.json→cloudflare-4.0.0.json,netskope_v2.json→netskope-1.0.0.json.-latestspecs kept the real vendor version ininfo.versioninstead of"latest"— now"latest", with the real version preserved inx-vendor-api-version.Cloudflare API→Cloudflare,Netskope REST API v2→Netskope).Studio Projects added
Built locally, one atomic workflow per operation. Not yet imported/tested against a live platform instance.
All specs confirmed importing successfully against a live platform instance, including the corrected identity (
Cloudflare:latest,Netskope:latest).