feat: Add skip-provisioning maintenance annotation for Device controller - #482
Open
nikatza wants to merge 1 commit into
Open
feat: Add skip-provisioning maintenance annotation for Device controller#482nikatza wants to merge 1 commit into
nikatza wants to merge 1 commit into
Conversation
nikatza
force-pushed
the
bypass-provisioning-v2
branch
3 times, most recently
from
August 6, 2026 09:21
06db757 to
550c5a6
Compare
The Device controller now supports a skip-provisioning value for the maintenance annotation. This allows devices that have been provisioned out-of-band to bypass the Provisioning phase while keeping the provisioning config in the spec for future reprovisioning. The controller handles the annotation in two phases. When a device is in Pending phase with spec.provisioning configured, the annotation causes a direct transition to Running without entering Provisioning. When a device is already in Provisioning phase, the annotation closes any active provisioning entry by setting its EndTime and transitions the device to Running. In both cases the annotation is consumed after processing and the controller emits a SkipProvisioning event. The reconcileMaintenance function was updated to preserve the annotation until it is consumed by the phase handlers. Updated the test infrastructure to support event verification. Drain and collect events from FakeRecorder into a a slice that tests can use. Signed-off-by: Pujol <enric.pujol@sap.com>
nikatza
force-pushed
the
bypass-provisioning-v2
branch
from
August 6, 2026 09:40
550c5a6 to
ec3c959
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
nikatza
marked this pull request as ready for review
August 6, 2026 11:42
adamtrizuljak-sap
self-requested a review
August 7, 2026 14:28
| testEvents = nil | ||
|
|
||
| DeferCleanup(func() { | ||
| Expect(client.IgnoreNotFound(k8sClient.Delete(ctx, secret))).To(Succeed()) |
Contributor
There was a problem hiding this comment.
Why IgnoreNotFound? The secret should still exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.