Skip to content

Fix CodeQL security alerts - #480

Merged
felix-kaestner merged 2 commits into
mainfrom
chore/security-alerts
Aug 7, 2026
Merged

Fix CodeQL security alerts#480
felix-kaestner merged 2 commits into
mainfrom
chore/security-alerts

Conversation

@felix-kaestner

Copy link
Copy Markdown
Contributor

This PR addresses the security alerts flagged by CodeQL:

@felix-kaestner
felix-kaestner force-pushed the chore/security-alerts branch 2 times, most recently from 51a2426 to 197d767 Compare August 4, 2026 13:18
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx 65.05% (-0.18%) 👎
github.com/ironcore-dev/network-operator/internal/controller/core 61.93% (+0.28%) 👍
github.com/ironcore-dev/network-operator/internal/tftp 74.63% (-6.33%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/internal/tftp/server.go 74.63% (-6.33%) 67 (+4) 50 (-1) 17 (+5) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/bordergateway_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/system_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/vpcdomain_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/acl_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/banner_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/bgp_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/bgp_peer_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/certificate_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/device_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/dhcprelay_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/dns_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/ethernetsegment_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/evpninstance_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/interface_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/isis_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/lldp_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/managementaccess_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/ntp_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/nve_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/ospf_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/pim_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/prefixset_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/routingpolicy_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/snmp_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/syslog_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/user_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/vlan_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/vrf_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/tftp/server_test.go

Add npm overrides to force vite ~6.4.3 and esbuild ~0.25.0,
resolving GHSA-4w7w-66w2-5vf9, GHSA-v6wh-96g9-6wx3,
GHSA-fx2h-pf6j-xcff, and GHSA-67mh-4wv8-2f99.

Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Set permissions to contents: read on workflows that had no
explicit permissions block, following the principle of least
privilege.

Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
@felix-kaestner
felix-kaestner force-pushed the chore/security-alerts branch from 197d767 to eb1682c Compare August 5, 2026 08:15
@felix-kaestner
felix-kaestner merged commit aa40ebe into main Aug 7, 2026
24 checks passed
@felix-kaestner
felix-kaestner deleted the chore/security-alerts branch August 7, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants