Skip to content

Bump coredhcp to use go-native sqlite - #465

Open
damyan wants to merge 1 commit into
mainfrom
enh/bump-coredhcp
Open

Bump coredhcp to use go-native sqlite#465
damyan wants to merge 1 commit into
mainfrom
enh/bump-coredhcp

Conversation

@damyan

@damyan damyan commented Aug 6, 2026

Copy link
Copy Markdown
Member

See https://github.com/damyan/coredhcp/tree/enh/use-gosqlite

Fixes #460

Summary by CodeRabbit

  • Chores
    • Updated the CoreDHCP dependency source to a newer version.

@damyan
damyan requested a review from a team as a code owner August 6, 2026 12:24
@github-actions github-actions Bot added the enhancement New feature or request label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@damyan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8285b18b-6e31-4a42-97c6-f9a8bf8927c8

📥 Commits

Reviewing files that changed from the base of the PR and between 629c656 and 976c5f4.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
📝 Walkthrough

Walkthrough

The PR updates the github.com/coredhcp/coredhcp replacement in go.mod to a newer github.com/damyan/coredhcp pseudo-version.

Changes

CoreDHCP module update

Layer / File(s) Summary
Update CoreDHCP replacement version
go.mod
The replacement target changes from v0.0.0-20260119103218-a013eb017f18 to v0.0.0-20260806121706-09c61d00f7f3.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: adracus

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating coredhcp to use Go-native SQLite support.
Description check ✅ Passed The description identifies the referenced coredhcp change and links the issue being fixed, but it omits the template headings and bullet structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch enh/bump-coredhcp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

See https://github.com/damyan/coredhcp/tree/enh/use-gosqlite

Signed-off-by: Damyan Yordanov <damyan.yordanov@sap.com>
@damyan
damyan force-pushed the enh/bump-coredhcp branch from 26f8665 to 976c5f4 Compare August 6, 2026 12:29
@damyan
damyan enabled auto-merge (squash) August 6, 2026 12:36
@simontesar

Copy link
Copy Markdown

I just tested and this solves the problem with the range plugin I described in #460 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabled CGO potentially breaks some upstream coredhcp plugins

2 participants