Repository navigation
Add gridded rumple with two surface methods - #55
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
calculate_rumple_grid()to calculate a rumple map from a CHM, with separate surface and output resolutions. For example, a 1 m CHM can produce a 20 m rumple raster.calculate_rumple()returns one value for the whole CHM.Both functions accept
method="two_triangle"(default) ormethod="jenness". Two-triangle excludes any patch with a missing height from both surface and ground area. Jenness omits missing center cells and uses the center height for missing neighbors, following lidR's raster calculation. Optional interpolation fills heights during CHM creation.min_heighttreats low heights as missing without modifying the input CHM.Includes tiled GeoTIFF output, documentation of the methods and missing-data rules, and an executed notebook showing both methods. Also updates the PDAL requirement to match the bindings installed in CI.
Validation: 185 tests passed, with one slow integration test skipped. Jenness matches reference values generated in R with
sp::surfaceArea. The notebook ran end to end and the docs built successfully. The documentation revision was checked to leave executable Python and notebook code unchanged.