fix: Make the link to CONTRIBUTING.md absolute to fix dead linking in PR descriptions - #94
Merged
Merged
Conversation
natestemen
reviewed
Aug 17, 2026
natestemen
left a comment
natestemen
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure I see the issue. If I go to https://github.com/ionq/ionq-core-python/blob/main/.github/pull_request_template.md in the browser, or open that file locally in vscode, the link works correctly.
Contributor
Author
|
@natestemen it doesn't work when clicking on the link from the PR description itself (its "main" location) |
Contributor
Author
|
hodgestar-ionq
approved these changes
Aug 18, 2026
hodgestar-ionq
left a comment
hodgestar-ionq
left a comment
There was a problem hiding this comment.
+1 on the change.
Given that the template might appear in many kinds of places (e.g. a PR page as @antalszava mentioned) a relative link seems fragile.
antalszava
force-pushed
the
fix_contributing_link_pr_template
branch
from
August 18, 2026 11:25
3a82d98 to
a781856
Compare
antalszava
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The link in this PR template at the end of the section is dead linking to the Contributing page (when accessed from a PR's description):
https://github.com/ionq/ionq-core-python/blob/main/CONTRIBUTING.md#proposing-changes
Test plan
Important
Most code in
ionq_core/is auto-generated and overwritten on regeneration.See CONTRIBUTING.md for which files are safe to edit.