Repository navigation
chore(vue): use Ionic lint and Prettier configs and replace Cypress with Playwright - #1917
Merged
Merged
Conversation
This was referenced Oct 23, 2026
brandyscarney
marked this pull request as ready for review
October 26, 2026 14:08
brandyscarney
force-pushed
the
chore/vue-vite-tooling
branch
from
October 27, 2026 15:25
e07a5a4 to
7a635e4
Compare
brandyscarney
force-pushed
the
chore/vue-vite-tooling
branch
from
October 27, 2026 19:27
7a635e4 to
cf39b80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Brings the
vue-vitestarters in line with the Ionic tutorial app (tutorial-photo-gallery-vue), so an app created withionic starthas the same lint, formatting, and test setup the tutorials teach against.New Behavior
Apps generated from the Vue starters now:
@ionic/eslint-config, alongsideeslint-plugin-vueand@vue/eslint-config-typescript. They format with Prettier and@ionic/prettier-config.npm run lintchecks both andnpm run lint:fixfixes both.lint,lint:fix,test,test:unit,test:unit:watch, andtest:e2e.npm run lintalso type-checks the Playwright tests andplaywright.config.ts, which Playwright and ESLint don't do on their own.Changes
base:.eslintrc.cjsand.eslintignorewitheslint.config.js..prettierignore(skipsandroid/andios/)..editorconfig.playwright.config.ts..gitignore.tsconfig.e2e.jsonand atypecheck:e2escript, run fromlint, plus@types/nodeforplaywright.config.ts.@eslint/js,@ionic/eslint-config,@ionic/prettier-config,@playwright/test,globals, andprettier.eslint-plugin-vue10,@vue/eslint-config-typescript14, Vitest 5, jsdom 30, andvue-tsc3.cypress.vite.config.tsonly collects unit tests fromtests/unit(*.spec.tsor*.spec.js, so the docs' "Build with JavaScript" steps keep working).tests/e2e/specs/test.cy.tsis now an equivalenttests/e2e/app.spec.ts.ionic.starter.jsontest script now runs lint, build, unit tests, then Playwright e2e, withoutconcurrently.Notes
main.tskeep their original order, so the CSS cascade is unchanged.npm run starters:testfor all four templates.