Repository navigation
chore(angular): update to Angular 22.2 and Vitest 5 - #1912
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, all six open Dependabot PRs fail CI. The Angular 22.2 group in #1911 breaks unit tests in the NgModule starters, the Vitest 5 bumps in #1909 and #1910 can't install until Angular is on 22.2, the security bump in #1904 moves
@angular/routerwithout the rest of the family, and the TypeScript 7 bumps in #1896 and #1898 can't install because no Angular release supports it yet.The test break comes from the 22.2 unit test builder only compiling spec files and what they import, so the
src/**/*.module.tsinclude intsconfig.spec.jsonno longer pulls NgModules into the compile. Specs that declare a component directly end up compiling it with no Ionic elements in scope, and everyion-*tag fails with NG8001.What is the new behavior?
Bumps the
@angular/*family to 22.2.3 and Vitest to 5.0.5 in both bases, which also covers the router security bump. The NgModule specs now import the module that declares their component, the same way thelisthome andtabstab specs already did. The sidemenuAppComponentspec also waits forion-menuto load inafterEach, since@ionic/angular/lazyfinishes loading it after teardown and Vitest 5 fails the run on logs from a closed environment.Dependabot now ignores TypeScript majors, since
@angular/buildand@angular/compiler-clipeer on>=6.0 <6.1.Does this introduce a breaking change?
Other information
Supersedes #1911, #1910, #1909, and #1904. I'm closing #1896 and #1898 too, since TypeScript 7 has to wait for Angular.
All eight Angular starters pass lint, build, and tests locally. Without the
afterEach, the sidemenu spec failed 4 of 8 runs under Vitest 5, and with it 0 of 10.