Repository navigation
fix(angular): populate tabs outlet before initial ionTabsWillChange - #31677
Open
duongynhi000005-oss wants to merge 1 commit into
Open
duongynhi000005-oss wants to merge 1 commit into
duongynhi000005-oss wants to merge 1 commit into
Conversation
Pass the `#outlet` template reference into `onStackWillChange` in both standalone and lazy `IonTabs` templates and assign `this.outlet` prior to emitting `ionTabsWillChange` when the `@ViewChild` query has not resolved yet. Resolves ionic-team#31674
|
@duongynhi000005-oss is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31674
What is the current behavior?
When
ion-tabsrenders after the router has already activated a child tab route (for example behind*ngIf/@if, or when hosted under Angular's<router-outlet>instead ofion-router-outlet), the inner<ion-router-outlet #outlet>activates the initial tab duringIonTabs' first change detection pass before the non-static@ViewChild('outlet')query resolves. As a result,tabs.outletisundefinedinside the firstionTabsWillChangehandler, and callingtabs.getSelected()throwsTypeError: Cannot read properties of undefined (reading 'getActiveStackId').What is the new behavior?
#outlettemplate reference intoonStackWillChange($event, outlet)in both the standalone (packages/angular/src/standalone/navigation/tabs.ts) and lazy (packages/angular/src/lazy/directives/navigation/ion-tabs.ts)IonTabstemplates.this.outletinIonTabs.onStackWillChange(packages/angular/src/common/directives/navigation/tabs.ts) before emittingionTabsWillChangeif the@ViewChildquery has not populated it yet.IonTabsverifyingtabs.outletis defined andtabs.getSelected()does not throw on the initialionTabsWillChangeemission whenion-tabsinitializes after route activation.Does this introduce a breaking change?
Other information
onStackWillChange's secondoutletparameter is optional so existing internal/subclass call sites remain backward-compatible.