Repository navigation
fix(reorder-group): use fractional item heights when calculating swap points - #31676
Open
ShryukGrandhi wants to merge 1 commit into
Open
ShryukGrandhi wants to merge 1 commit into
ShryukGrandhi wants to merge 1 commit into
Conversation
… points Signed-off-by: ShryukGrandhi <85529990+ShryukGrandhi@users.noreply.github.com>
|
@ShryukGrandhi is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31670
What is the current behavior?
When a drag starts,
ion-reorder-groupcaches where each item ends by summingoffsetHeightfor each child.offsetHeightis rounded to a whole pixel, so items with fractional heights (for example 64.5px) add up to half a pixel of error per row. The swap point drifts further from where it should be the further down the list you go.What is the new behavior?
getBoundingClientRect().height, which keeps fractional heights. The swap point stays aligned at every row.toindex is correct. Without the fix it reports 24 instead of 25.Does this introduce a breaking change?
Other information
Tested locally with
npx playwright test src/components/reorder-group/ --project="Mobile Chrome". The new test fails before the change and passes after it, and the other reorder-group behavior tests still pass. The only failures were the a11y font-scaling screenshot tests, which have no darwin baselines on my machine.Fixes #31670