Skip to content

test(scripts): default the test page theme to the mode #31672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thetaPC merged 1 commit into from
Nov 3, 2026
Merged

test(scripts): default the test page theme to the mode #31672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions core/scripts/testing/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* - `rtl`: Set to `true` to enable right-to-left directionality.
* - `ionic:_testing`: Set to `true` to identify testing environments.
* - `ionic:theme`: Set to `ionic`, `ios`, `md` or `base` to load a specific
* theme. Defaults to `md`.
* theme. Defaults to the mode, then `md`.
* - `palette`: Set to `light`, `dark`, `high-contrast`, or
* `high-contrast-dark` to load a specific palette. Defaults to `light`.
*/
Expand Down Expand Up @@ -53,14 +53,19 @@ const DEFAULT_PALETTE = 'light';

/**
* The `theme` param is used to load a specific theme.
* This can be `ionic`, `ios`, `md`, or `base`. Default to `md` for tests.
* This can be `ionic`, `ios`, `md`, or `base`. Defaults to the mode, as in
* the app, then to `md`.
* `base` loads only the base tokens, with no component tokens, to show
* how migrated components render without a theme.
*/
const themeQuery = window.location.search.match(/ionic:theme=([a-z0-9]+)/i);
const themeHash = window.location.hash.match(/ionic:theme=([a-z0-9]+)/i);
const themeAttr = document.documentElement.getAttribute('theme');
const themeName = themeQuery?.[1] || themeHash?.[1] || themeAttr || DEFAULT_THEME;
const modeQuery = window.location.search.match(/ionic:mode=([a-z]+)/i);
const modeHash = window.location.hash.match(/ionic:mode=([a-z]+)/i);
const modeAttr = document.documentElement.getAttribute('mode');
const modeName = modeQuery?.[1] || modeHash?.[1] || modeAttr;
const themeName = themeQuery?.[1] || themeHash?.[1] || themeAttr || modeName || DEFAULT_THEME;

// TODO(): Remove this when the tokens are working for all components
// and the themes all use the same bundle
Expand Down
Loading