Skip to content

refactor(themes): align recipe keys, interface files and prop arrays - #31671

Open
thetaPC wants to merge 2 commits into
ionic-modularfrom
recipe-nested-keys
Open

thetaPC wants to merge 2 commits into
ionic-modularfrom
recipe-nested-keys

Conversation

@thetaPC

@thetaPC thetaPC commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Issue number: internal


What is the current behavior?

Migrated components follow different conventions:

  • Some recipe keys are flat (lineHeight, minHeight), while others nest under a shared CSS prefix (min: { height }). ion-title nests letter: { spacing }, even though no other CSS property starts with letter-.
  • Some interface files are plural (badge.interfaces.ts), while newer ones are singular (title.interface.ts).
  • ion-chip and ion-spinner declare their prop unions inline, so their tests hardcode the values.

What is the new behavior?

  • Nests the remaining flat keys: line.height and min.height in ion-chip, min.height in ion-item-divider, and line.height in ion-skeleton-text.
  • Flattens letter.spacing in ion-title to letterSpacing, matching ion-badge and ion-chip.
  • Renames the plural interface files to singular. themes.interfaces.ts stays plural.
  • Adds ION_CHIP_FILLS, ION_CHIP_SIZES, ION_CHIP_SHAPES and ION_SPINNER_SIZES. The chip, spinner and tab-button badge tests now loop over these and the ION_BADGE_* arrays.
  • The generated theme CSS is identical before and after.

Does this introduce a breaking change?

  • Yes
  • No

These recipes and file names haven't been released yet.

@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Oct 29, 2026 9:44pm UTC

Request Review

@thetaPC thetaPC changed the title refactor(themes): align recipe key nesting and interface file names refactor(themes): align recipe keys, interface files and prop arrays Oct 29, 2026
@thetaPC
thetaPC marked this pull request as ready for review October 29, 2026 22:20
@thetaPC
thetaPC requested a review from a team as a code owner October 29, 2026 22:20
@thetaPC
thetaPC requested a review from ShaneK October 29, 2026 22:20

This branch was successfully deployed

1 active deployment
Preview — aaacec3f Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant