Repository navigation
chore(deps): update lock files to resolve security alerts - #31616
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
left a comment
There was a problem hiding this comment.
Approved with comments!
| /** | ||
| * `ChildrenOutletContexts` keeps each outlet's context in a private `contexts` | ||
| * map. Saving and restoring it preserves tab state. | ||
| */ |
There was a problem hiding this comment.
Could the comment say this field isn't in Angular’s public typings, so it gets checked on upgrades? Something like:
| /** | |
| * `ChildrenOutletContexts` keeps each outlet's context in a private `contexts` | |
| * map. Saving and restoring it preserves tab state. | |
| */ | |
| /** | |
| * `ChildrenOutletContexts` keeps each outlet's context in a private `contexts` | |
| * map that is not part of Angular's public typings. Saving and restoring it | |
| * preserves tab state, so confirm the field still exists when upgrading Angular. | |
| */ |
There was a problem hiding this comment.
npm audit --package-lock-only still shows high alerts for picomatch 2.3.1 (core, react, vue), semver 6.3.0/7.3.7/5.7.1 (core), micromatch (core, react) and vite 7.3.6 (migrate). These look fixable within the current ranges, and the angular lock file already has picomatch 2.3.2. Could you refresh these, or call them out under Other information if they're being left on purpose?
There was a problem hiding this comment.
Refreshed in de930f4. The update was based on open Dependabot alerts, and Dependabot had auto-dismissed the picomatch and semver ones as dev-scoped, so they never showed up. The vite advisory in migrate was published the day the update ran. vite is pinned to 7.3.7 since a plain npm update jumps to vite 8. npm audit --package-lock-only now only reports the postcss 7 from stylelint 13, which is already called out under Other information.
…grades Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
Issue number: resolves internal
What is the current behavior?
Dependabot and
npm auditreport high and critical alerts against the lock files incoreandpackages/*. None of them reach users: lock files are not published, and our declared ranges already resolve to the patched versions on a fresh install. The alerts are noise that can bury a real one.What is the new behavior?
coreforcompressionunderserve, since the latestservepins the vulnerable version. Remove it once aserverelease includes fix(compression): bump compression to 1.8.2 vercel/serve#868.migratemoves tovite7.3.7 rather than the latest 8.x, which would swap its test bundler for Rolldown.contextsfield from theChildrenOutletContextstypings, soion-router-outletnow casts to a local type when it saves and restores tab state. The field still exists at runtime, so behavior is unchanged.@angular/cli22.2 no longer bundles its MCP server, which accounts for most of the removals in the Angular lock file.Does this introduce a breaking change?
Other information
Test app and root lock files are updated in #31617. The
postcss7 alerts incoreremain: they come fromstylelint13 and need astylelintupgrade, as noted in #31436.