Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: ionic-team/ionic-framework#31442
What is the current behavior?
The v10 migration guide has no Angular section. Boolean inputs on Ionic components are getting an input transform in v10, and nothing documents it.
What is the new behavior?
Adds Getting Started > Angular > Boolean Inputs to the v10 migration guide, covering:
<ion-item button>, which previously failed to compile[button]="items.length"now fails withTS2322and needs coercingnullandundefinedpass through instead of coercing tofalse, the opposite of Angular's ownbooleanAttribute, because components likeion-itemand sheetion-modaltreat "not set" as a third stateDoes this introduce a breaking change?
Other information
N/A