Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Add support for additional Skip and Take scenarios  #10

Description

@sflanker

There are a number of edge cases for Skip and Take that aren't supported:

  1. Calling Skip without subsequently calling Take
  2. Calling Skip multiple times
  3. Calling Take multiple times

It should be possible to support all of these scenarios. Multiple calls can be folded into a single call in trivial cases. In more complicated scenarios involving mixed calls to Where and Skip/Take it will be necessary to generate a subquery. A Skip without any Take can be implemented with session variables.

Test case overrides:

[Fact(Skip = "TODO: Not Supported (Skip must be combined with Take)")]
public override void Skip() {
}
[Fact(Skip = "TODO: Not Supported (Multiple Skips not supported)")]
public override void Skip_Skip() {
}
[Fact(Skip = "TODO: Not Supported (Multiple Takes not supported)")]
public override void Take_Take() {
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions