Repository navigation
feat: registry file_triggers map changed paths straight to journeys (#118) - #146
Merged
Merged
Conversation
…118) `"file_triggers": {"<glob>": ["J1", ...]}` declares dependencies the graph cannot model (SQL migrations -> RLS). Globs are repo-relative, whole-path, `**` / `*` / `?`, matched against every raw diff path before the product filter. Additive: a graph-selected journey gains `triggered_by`; a trigger-only journey gets a confident `file-trigger` row. A matched unmodeled path is declared covered and no longer forces the #117 all-journeys fallback; an unmatched one still does. Invalid triggers (bad glob, empty list, unknown journey id) BLOCK. In passing: #136 caps the unmodeled-path list in its warning; #138 gives unmodeled fallback rows their own reason and warning.
…export map (#118 review) - H1: export lists file_triggers in the map (## File triggers) and the --json sidecar, and refuses an invalid trigger like select does; the verify skill unions matching triggers into the set. - H2: a glob with an empty, `.` or `..` segment, or `**` inside a segment, can never match a file and now BLOCKs instead of dropping the declared journeys behind a clean NONE. - H3: a trailing `**` matches a path containing a newline. - H4: at most two `**` segments per glob; more backtracked for >20s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118. Also fixes #136 and #138.
"file_triggers": {"<glob>": ["J1", ...]}in a registry. Globs are repo-relative and match the whole path;**is whole segments only (at most 2),*and?stay within a segment. They are matched against every raw diff path, before the product filter.triggered_by; a trigger-only journey gets a confidentfile-triggerrow. A matched unmodeled path no longer forces the P1: Unindexed behavior-changing diffs must return UNKNOWN or select all journeys #117 all-journeys fallback; an unmatched one still does.--jsonsidecar list the triggers, and the verify skill adds matching triggers' journeys to the set.Reviewed by /code-review and a code-reviewer agent. The high-severity findings are fixed in e7f754f; the rest are filed as #142–#145.