Repository navigation
fix: an unmodeled diff path degrades to every journey; verify's UNKNOWN NONE is not a pass (#117, #113) - #141
Merged
Conversation
…WN NONE is not a pass (#117, #113) #117: the diff parser dropped every path outside PRODUCT_EXT before impact analysis, so a migration-, Dockerfile-, CI- or CSS-only diff answered "0 changed files, NONE" with no warning. Every path is now accounted for (diff_files) and classified: product (seeded as before), exempt with a reason (test, docs, type declaration), or unmodeled, which joins the #29 unmapped fallback: warning, recall_degraded, every journey listed verify_manually. select names each unmodeled path; the hook gives them a capped NOTE line of their own. #113: verify's NONE headline read "nothing to verify" with the UNKNOWN reasons indented below it. It now uses select's two-sentence headline, and an UNKNOWN empty selection exits 3 instead of 0.
- H1: --submodule=short --ignore-submodules=none, so diff.ignoreSubmodules, a .gitmodules ignore or diff.submodule=log cannot hide a submodule bump. - H2: doc basenames match exactly (optionally with a prose extension); the prefix match exempted db/authors.sql and config/licenses.json. - H3: only a test directory exempts a non-code file; _is_test's name rules exempted test_and_deploy.yml and openapi.spec.yaml. - H4: verify's exit decision ignores entries_unchecked, which never clears; the headline still shows it. - H5: docs/ and doc/ exempt only at the top level. - verify --help epilog and a misplaced comment updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117 and #113.
diff_files). Product paths are seeded as before. Tests (under a test directory), docs (.md/.rst/.adoc, top-leveldocs//doc/, exact LICENSE/COPYING/CHANGELOG/NOTICE/AUTHORS) and.d.tsfiles are exempt with a reason (exempt_files). Every other path (unmodeled_files) triggers the Changed product file with zero index nodes still yields a confident NONE #29 all-journeys fallback, and select and the hook name each one.git diffpins--submodule=short --ignore-submodules=none, so git config can't hide a submodule bump.Reviewed by /code-review and a code-reviewer agent. The high-severity findings are fixed in 935bc0c; the rest are filed as #136–#140.