fix(analysis): treat a deleted analysis (410 Gone) as a missing one - #182
Merged
Merged
Conversation
The api service returns 410 Gone for an analysis that was deleted, expired or deprecated, so FileAnalysis/UrlAnalysis/EndpointAnalysis.from_analysis_id raised requests.HTTPError instead of returning None as documented, breaking cleanup paths that rely on the missing-analysis contract. Ref: TKT-18644 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
liamkz
approved these changes
Sep 14, 2026
or-saiag-eliezer
changed the title
almogch
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deleted analysis answers 410 Gone, but
ignore_not_foundonly tolerated 404, sofrom_analysis_idraised instead of returningNone— contradicting its own docstring. This treats gone and missing alike.