change ShellScript() to return a status - #1211
Merged
Merged
Conversation
isc-cborbonm
requested review from
isc-dchui,
isc-egabhart,
isc-eneil,
isc-jili,
isc-jlechtne,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
July 29, 2026 15:58
isc-kiyer
reviewed
Jul 29, 2026
isc-eneil
previously approved these changes
Jul 29, 2026
isc-kiyer
reviewed
Jul 29, 2026
| pOutputLogFile As %String = "", | ||
| pAppendToLog As %Boolean = 0) | ||
| pAppendToLog As %Boolean = 0, | ||
| terminateOnError As %Boolean = 1) As %Status |
Collaborator
There was a problem hiding this comment.
Nit: when editing an existing method, stick to the style of that method (use the p prefix here)
isc-jili
approved these changes
Jul 29, 2026
Collaborator
Author
Yeah! I could also unlink it, so that it doesn't close the issue. Would that be preferable? |
Collaborator
|
@isc-cborbonm It depends on the scope. If this change fixes a legitimate distinct problem, which it sounds like it does, then I think it should have an issue attached. |
Collaborator
Author
Created new issue #1213 to implement the teeing output feature! 😃 |
isc-dchui
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1186: change ShellScript() to return a status.