Skip to content

Fix compile new bpl - #986

Merged
isc-pbarton merged 3 commits into
mainfrom
fix-compile-new-bpl
Jul 24, 2026
Merged

Fix compile new bpl#986
isc-pbarton merged 3 commits into
mainfrom
fix-compile-new-bpl

Conversation

@isc-pbarton

Copy link
Copy Markdown
Collaborator

Description

Resolves #984
Fixes two unrelated bugs causing compilation failures:

  • logic to auto add bpl/br to source control assumed that if compiled class dictionary exists it is runnable, which is apparently not true
  • RefreshUncommitted calls a git status and output is incorrectly parsed, leading it to try to look up internal name for an empty string.

Testing

A little hard to unit test because it only occurs in certain edge cases in the compile chain. Manual testing:
docker compose up -d --build
do ##class(SourceControl.Git.API).Configure()
enter in prompts to initialize git repository, accepting all other defaults.
http://localhost:52774/csp/sys/UtilHome.csp
Create a new business process (simplest compilable one: just add one Trace block, set value to 1, then hook it up to the input and output).
Save the business process
Compile. Prior to this change, it failed to compile. Now, it successfully compiles.
Open Git Web UI and confirm the new business process was automatically exported to the Git workspace.

Checklist

  • This branch has the latest changes from the main branch rebased or merged.
  • [N/A] Web UI has been built (any changes in git-webui/src have matching changes in git-webui/release)
  • CHANGELOG.md entry added if appropriate.
  • [N/A] Documentation has been/will be updated

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.15%. Comparing base (c12184c) to head (f018f5f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   49.14%   49.15%   +0.01%     
==========================================
  Files          22       22              
  Lines        3315     3316       +1     
==========================================
+ Hits         1629     1630       +1     
  Misses       1686     1686              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isc-pbarton
isc-pbarton merged commit cbbfdbf into main Jul 24, 2026
2 checks passed
@isc-pbarton
isc-pbarton deleted the fix-compile-new-bpl branch July 24, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compilation errors on new business processes when production decomposition is disabled

3 participants