Skip to content

[PB-6545]: feature/apply cancellation trial#415

Merged
xabg2 merged 4 commits into
masterfrom
feat/types-for-mailbox-emails
Jul 6, 2026
Merged

[PB-6545]: feature/apply cancellation trial#415
xabg2 merged 4 commits into
masterfrom
feat/types-for-mailbox-emails

Conversation

@xabg2

@xabg2 xabg2 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What's new:

  • New EP to apply the cancellation trial for elegible users.
  • New types so we can know if the user is elegible or not to the cancellation trial (if the user already redeemed it or not).

Summary by CodeRabbit

  • New Features

    • Added a new payments action to apply a cancellation trial for a subscription.
  • Chores

    • Bumped the package version from 1.17.11 to 1.17.12.
  • Developer Experience

    • Updated payment-related types to better reflect cancellation trial and commitment details.

@xabg2 xabg2 requested a review from larryrider July 6, 2026 08:39
@xabg2 xabg2 self-assigned this Jul 6, 2026
@xabg2 xabg2 added the enhancement New feature or request label Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 192f1c99-9be9-4db5-bd9f-aee88c148dcf

📥 Commits

Reviewing files that changed from the base of the PR and between 5cb538c and 288cb5b.

📒 Files selected for processing (3)
  • package.json
  • src/drive/payments/index.ts
  • src/drive/payments/types/types.ts

📝 Walkthrough

Walkthrough

This PR adds a Commitment type, updates StoragePlan's commitment and cancellationTrial field structures, adds a new applyCancellationTrial method to the Payments class that POSTs to a cancellation-trial endpoint, and bumps the package version.

Changes

Cancellation Trial Feature

Layer / File(s) Summary
Commitment and StoragePlan type updates
src/drive/payments/types/types.ts
Adds exported Commitment type with enabled, and optional remainingMonths, cancellationDate, isElegibleForCancellation; updates StoragePlan's commitment field to use Commitment and adds redeemed: boolean to cancellationTrial.
applyCancellationTrial API method
src/drive/payments/index.ts
Adds public applyCancellationTrial(subscriptionId) method to Payments, issuing a POST request to /customer/cancellation-trial.
Package version bump
package.json
Bumps version from 1.17.11 to 1.17.12.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Related PRs: None identified.

Suggested labels: None

Suggested reviewers: None

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding cancellation trial application support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/types-for-mailbox-emails

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@xabg2 xabg2 merged commit b61d9e7 into master Jul 6, 2026
1 check passed
@xabg2 xabg2 deleted the feat/types-for-mailbox-emails branch July 6, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants