[PB-6505] Use set user#2024
Open
TamaraFinogina wants to merge 6 commits into
Open
Conversation
Deploying drive-web with
|
| Latest commit: |
c73bbd4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95698600.drive-web.pages.dev |
| Branch Preview URL: | https://use-setuser.drive-web.pages.dev |
larryrider
reviewed
Jul 7, 2026
| } | ||
|
|
||
| function setUser(user: UserSettings): void { | ||
| set(LocalStorageItem.UserUUID, user.uuid); |
Contributor
There was a problem hiding this comment.
Why saving the user uuid in a new localStorage var, if the user is still going to be saved, and the uuid is already there? 🤔
Contributor
Author
There was a problem hiding this comment.
Because the user will be encrypted, so, getting back up keys (getBackupKeyStorageKeys()) will require 1 decryption. Yet, it only needs the UUID, which is not secret and can be stored without any encryption at all.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the unused email field and switches to the setUser function instead of setting it directly in local storage.
Related Issues
Relates to PB-6505
Checklist
Testing Process
unit tests
Additional Notes
setUser/getUser will be needed for adding encryption