[PB-6545]: feature/cancellation trial flow#2022
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying drive-web with
|
| Latest commit: |
64b2469
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d32b0763.drive-web.pages.dev |
| Branch Preview URL: | https://feature-cancel-subscription.drive-web.pages.dev |
| <div className="mt-5 flex justify-end"> | ||
| <Button | ||
| className={'shadow-subtle-hard'} | ||
| className={'shadow-su0btle-hard'} |
There was a problem hiding this comment.
I think that the 0 has slipped in
| currentUsage, | ||
| cancellingSubscription, | ||
| cancelSubscription, | ||
| applyingTrial = false, |
There was a problem hiding this comment.
I would use is, has, etc, as convention for boolean fields. The exception we usually make is if they mimic an HTML attribute, which is typically something like (disabled, active, etc.) which is typically found in components
There was a problem hiding this comment.
I agree, but as we were already using cancellingSubscription, I followed the same convention, although I really should have corrected it, my bad.
| onCancelSuccess, | ||
| }: UseSubscriptionCancellationOptions): UseSubscriptionCancellationResult => { | ||
| const dispatch = useAppDispatch(); | ||
| const [cancellingSubscription, setCancellingSubscription] = useState<boolean>(false); |
|
Hey @CandelR , I also fixed the date we display when redeeming the cancellation incentive. We should display the next billing day + 30 days, not + 30 days from today. |
|
3 participants
Description
A new flow has been implemented that allows users with a subscription of less than one month to redeem a free month and receive an additional 30-day cancellation guarantee, enabling them to cancel their plan immediately.
We implemented a new modal that appears when a user tries to cancel their subscription during the first month.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes