[MKT-881]:feat/improve GA service pushes#2014
Draft
jaaaaavier wants to merge 2 commits into
Draft
Conversation
Deploying drive-web with
|
| Latest commit: |
c36b288
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6103a28a.drive-web.pages.dev |
| Branch Preview URL: | https://feat-ga-service-improves.drive-web.pages.dev |
| const value = Number.parseFloat(amountPaid); | ||
|
|
||
| const eventId = | ||
| localStorageService.get('subscriptionId') ?? |
Contributor
There was a problem hiding this comment.
Now you need localStorageService.get(LocalStorageItem.SubscriptionID);
TamaraFinogina
requested changes
Jul 2, 2026
TamaraFinogina
left a comment
TamaraFinogina
left a comment
Contributor
There was a problem hiding this comment.
localStorageService.get now only accepts LocalStorageItem as input, won't work otherwise. Please don't use strings
Contributor
Author
Perfect!! Thank you! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes