Fix search-provider.test.js to test constructor - #1583
Open
duggiefresh wants to merge 1 commit into
Open
Conversation
The `search-provider` test accidentally wrapped the constructor test in a `describe` block, which does not fire test expectations correctly. This PR updates the constructor test to use the `test` method instead. This adds to the total number of tests run, changing it from 8 tests to 9 tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1583 +/- ##
=======================================
Coverage 63.70% 63.70%
=======================================
Files 68 68
Lines 6216 6216
Branches 1378 1378
=======================================
Hits 3960 3960
Misses 2217 2217
Partials 39 39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
search-providertest accidentally wrapped the constructor test in adescribeblock, which does not fire test expectations correctly. This PR updates the constructor test to use thetestmethod instead.This adds to the total number of tests run, changing it from 8 tests to 9 tests.
Before
After