-
Notifications
You must be signed in to change notification settings - Fork 85
Module services api #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
desmonddak
wants to merge
113
commits into
intel:main
Choose a base branch
from
desmonddak:module_services_api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Module services api #673
Changes from all commits
Commits
Show all changes
113 commits
Select commit
Hold shift + click to select a range
82e900e
move synthesis naming to a common naming utility so all synthesizers …
desmonddak 85f88ce
dart 3.11 parameter_assignments pickiness
desmonddak b1de1e5
Merge branch 'main' into central_naming
desmonddak b7087c4
conflict resolved and dart format . works
desmonddak 4a55214
properly assign naming spaces for instances vs signals
desmonddak ed7be36
format issue
desmonddak ab09aed
Controllable enforcement of signal vs instance name uniqueness.
desmonddak 520d280
Refactored to Namer class. No external API changes for ROHD
desmonddak 61d0319
signal registry
desmonddak becdb36
module context name uniquification instead of signal/instance split
desmonddak a86f80c
Merge branch 'main' into central_naming
desmonddak d5904a6
cleanup of port vs signal name assumptions, constant merging and sign…
desmonddak 3645293
Add ModuleServices singleton and SvService
desmonddak 6dfe0f9
simplified forModule, improved code doc
desmonddak 3c90e5d
more coverage for Namer
desmonddak f918ec7
first passing version of SystemC translated tests
desmonddak 91604b1
SystemC and SV tests are comingled.
desmonddak 810eec7
we need sudo in installation scripts
desmonddak 6c39020
avoid a race and using a lock for SystemC
desmonddak 340af62
cascade introduced
desmonddak 0b4732b
use BigInt.one shifted instead of a platform-dependent constant
desmonddak 6aeb6aa
JS platform skip SystemC
desmonddak 832ef9f
cleanup tmp_test after systemc tests
desmonddak 4b92fc6
create test dir
desmonddak 824a191
cascade issue
desmonddak de589e5
yet another JS issue
desmonddak d0e985b
trying to match devcontainer to normal ci
desmonddak 60974d7
dart tests using ffi to drive systemc
desmonddak 1951d17
fixed recent analyzer failure (version change)
desmonddak e4d931d
skip FFI tests in CI as dart:ffi is not available
desmonddak 0ea6f1e
remove netlist leakage into this branch
desmonddak d1da6a2
module_services_test only on vm
desmonddak 1989dd0
resolve naming crash for systemc and ensure names are aligned
desmonddak 6ca2e8c
fix perf problem reported by Carlos
desmonddak cb11009
feat(systemc): scLineMap records all assignment LHS positions
desmonddak 881fb08
formatting
desmonddak 42fba62
canonical names at last, even in the comments
desmonddak 6a41f8d
pesky override rule surfaced again on tutorials file
desmonddak 139280f
new keyring-based installation for dart in codespaces
desmonddak 62e4a2c
new keyring-based installation for dart in codespaces
desmonddak caecb02
keyring-style dart installation rather than holding keys
desmonddak 089faf8
new dart analyzer failure with bad override
desmonddak e015889
Merge branch 'override-bug' into new-dart
desmonddak 1232afb
Potential fix for pull request finding
desmonddak e558a4d
Orthogonalize: simplify Namer by removing instance name caching
desmonddak 8ef6820
Fix orthogonalized Namer: remove stale instanceNameOf method
desmonddak 1225df1
Clean DevTools extension analysis and formatting
desmonddak c8440c4
Keep DevTools extension changes on owning branches
desmonddak 8a92fb9
first passing version of SystemC translated tests
desmonddak 4d467ce
SystemC and SV tests are comingled.
desmonddak f2d5fd6
avoid a race and using a lock for SystemC
desmonddak 09bd0b3
cascade introduced
desmonddak 4cb001b
use BigInt.one shifted instead of a platform-dependent constant
desmonddak 7b330d7
JS platform skip SystemC
desmonddak 1c9a706
cleanup tmp_test after systemc tests
desmonddak 9f79c7e
create test dir
desmonddak 3158f28
cascade issue
desmonddak 57aad95
yet another JS issue
desmonddak e821b4d
trying to match devcontainer to normal ci
desmonddak 274be02
dart tests using ffi to drive systemc
desmonddak 147b601
fixed recent analyzer failure (version change)
desmonddak bfd36d1
skip FFI tests in CI as dart:ffi is not available
desmonddak 8ea068e
remove netlist leakage into this branch
desmonddak 062be8a
resolve naming crash for systemc and ensure names are aligned
desmonddak 446b7e4
fix perf problem reported by Carlos
desmonddak b890de0
feat(systemc): scLineMap records all assignment LHS positions
desmonddak f6496bb
formatting
desmonddak df29290
Avoid shared SystemC simcompare temp files
desmonddak a87fa5c
added back pubkeys, and made a wget a fallback solution with loud war…
desmonddak 35558b0
trailing comma reduction
desmonddak d2760eb
Merge branch 'new-dart' into central_naming
desmonddak 04defe3
Merge branch 'new-dart' into systemc
desmonddak 9bbe55d
merge new-dart
desmonddak 4e332ca
Fix committed conflict markers in simcompare.dart
desmonddak fc690f3
Restrict module_services_test to VM platform
desmonddak b7e46c0
Add instanceNameOf to Namer: cached instance-name lookup
desmonddak 0f13c7b
Move instanceNameOf stability test to central_naming
desmonddak e2a07f9
Clean up tmp_test after SystemC tests
desmonddak 26a1abc
Fix tmp_test cleanup for FFI cosim test
desmonddak ca49954
Fix always_put_control_body_on_new_line lint in cleanupCache
desmonddak d4be883
Fix always_put_control_body_on_new_line in cleanupCache early return
desmonddak 319706b
Wire pickName through instanceNameOf for stable instance names
desmonddak 11bc2cd
Add instance-signal namespace collision stability tests
desmonddak 3b8a8a8
consistency in naming
desmonddak 41ef3cb
Clean up tmp_test after provider/consumer SystemC tests
desmonddak acf01a9
Self-clean tmp_test in checkSystemCVector (single-shot path)
desmonddak 9be2d45
Fix cleanupSystemCCache: use entity.path not entity.uri for name
desmonddak b0e97c1
Allow pch/ in check_tmp_test.sh (intentional PCH cache)
desmonddak 32797ec
Split base SystemC support from services
desmonddak 2c27014
Adapt SystemC support to central naming
desmonddak 9aaf558
Restore FFI cosim cleanupCache and use Node 24 in CI
desmonddak 6371036
Clean up Namer allocation API
desmonddak e06b6bb
Add ModuleServices singleton and SvService
desmonddak 9ca2a8f
Slim ModuleServices API branch
desmonddak 6429977
attempt to reduce conflict in module.dart
desmonddak 90fb738
Normalize module import spacing
desmonddak a88af28
Merge remote-tracking branch 'origin/systemc_naming' into module_serv…
desmonddak 4b27f90
conflict resolution after merging main
desmonddak 8529232
fix systemc installer
desmonddak fc2bcaa
systemc compiler cleanup
desmonddak e4ecc62
Remove SystemC changes from module services API
desmonddak 58cea41
Merge branch 'main' into module_services_api
desmonddak ab98dd2
enhance SvService with SystemVerilogSynthesizerConfiguration
desmonddak df8a606
Remove dart_test.yaml - only needed in branches with FFI tests
desmonddak ee6c7a3
fully deprecate WaveDumper, multiple review fixes
desmonddak 4db1142
deprecate generateSynth
desmonddak b8f5f63
refactor: Convert rootModule field to property with ModuleTree sync
desmonddak a6120e9
Merge remote-tracking branch 'upstream/main' into module_services_api
desmonddak 73e06a5
missed generateSynth calls
desmonddak e8bc6d3
cleanup module_services lookup and rootModule APIs
desmonddak d8dc42a
Support headers in multi-file SV output
desmonddak e98a0c0
single and multi-file header control for SV
desmonddak 8d9be73
cleaner ModuleTree update
desmonddak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Copyright (C) 2026 Intel Corporation | ||
| // SPDX-License-Identifier: BSD-3-Clause | ||
| // | ||
| // diagnostics.dart | ||
| // Barrel export for the diagnostics library. | ||
| // | ||
| // 2026 July 16 | ||
| // Author: Desmond Kirkpatrick <desmond.a.kirkpatrick@intel.com> | ||
|
|
||
| export 'module_service.dart'; | ||
| export 'module_services.dart'; | ||
| export 'waveform_service.dart'; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.